Changed a lot of the visibility in requirements to disable access for vicious plugin devs.

Author: sebinside

src/main/java/org/codeoverflow/chatoverflow/api/plugin/configuration/Requirement.java

@@ -39,7 +39,7 @@ public T get() {
      *
      * @param value the value of the requirement
      */
-    public void set(T value) {
+    void set(T value) {
         this.value = value;
     }
 
@@ -57,7 +57,7 @@ public String getName() {
      *
      * @param name a string to display to the user
      */
-    public void setName(String name) {
+    void setName(String name) {
         this.name = name;
     }
 
@@ -91,7 +91,7 @@ public boolean isOptional() {
      *
      * @param optional true, if the requirement does not need to be set
      */
-    public void setOptional(boolean optional) {
+    void setOptional(boolean optional) {
         isOptional = optional;
     }
 
@@ -100,7 +100,7 @@ public void setOptional(boolean optional) {
      *
      * @return A class object holding the value set while creating the requirement object
      */
-    public Class getTargetType() {
+    Class getTargetType() {
         return targetType;
     }
 

src/main/java/org/codeoverflow/chatoverflow/api/plugin/configuration/Requirements.java

@@ -71,7 +71,7 @@ private <T extends Serializable> Requirement<T> addRequirement(Map<String, Requi
      * @param uniqueRequirementId the plugin unique requirement id
      * @return an optional encapsulating the requirement or none
      */
-    public Optional<? extends Requirement<? extends Serializable>> getRequirementById(String uniqueRequirementId) {
+    Optional<? extends Requirement<? extends Serializable>> getRequirementById(String uniqueRequirementId) {
         return getAllEntries()
                 .filter(entry -> entry.getKey().equals(uniqueRequirementId))
                 .map(Map.Entry::getValue).findFirst();
@@ -83,7 +83,7 @@ public Optional<? extends Requirement<? extends Serializable>> getRequirementByI
      * @param uniqueRequirementId the plugin unique requirement id
      * @return true, if the requirement exists and previously had a value
      */
-    public boolean unsetRequirementById(String uniqueRequirementId) {
+    boolean unsetRequirementById(String uniqueRequirementId) {
         Optional<? extends Requirement<? extends Serializable>> requirement =
                 getAllEntries().filter(entry -> entry.getKey().equals(uniqueRequirementId))
                         .map(Map.Entry::getValue).findFirst();
@@ -98,7 +98,7 @@ public boolean unsetRequirementById(String uniqueRequirementId) {
      *
      * @return true, if all needed requirements had been set
      */
-    public Boolean isComplete() {
+    Boolean isComplete() {
         return getAllEntries()
                 .map(Map.Entry::getValue)
                 .allMatch(req -> req.isSet() || req.isOptional());
@@ -109,7 +109,7 @@ public Boolean isComplete() {
      *
      * @return a list of unique requirement ids
      */
-    public List<Requirement<? extends Serializable>> getMissingRequirements() {
+    List<Requirement<? extends Serializable>> getMissingRequirements() {
         return getAllEntries()
                 .filter(entry -> !entry.getValue().isSet())
                 .map(Map.Entry::getValue)
@@ -122,19 +122,19 @@ private Stream<Map.Entry<String, Requirement<? extends Serializable>>> getAllEnt
                 parameterRequirements.entrySet().stream()).reduce(Stream::concat).get();
     }
 
-    public Map<String, Requirement<? extends Serializable>> getRequirementMap() {
+    Map<String, Requirement<? extends Serializable>> getRequirementMap() {
         return getAllEntries().collect(Collectors.toMap(Map.Entry::getKey, Map.Entry::getValue));
     }
 
-    public Collection<Requirement<? extends Serializable>> getInputRequirements() {
+    Collection<Requirement<? extends Serializable>> getInputRequirements() {
         return inputRequirements.values();
     }
 
-    public Collection<Requirement<? extends Serializable>> getOutputRequirements() {
+    Collection<Requirement<? extends Serializable>> getOutputRequirements() {
         return outputRequirements.values();
     }
 
-    public Collection<Requirement<? extends Serializable>> getParameterRequirements() {
+    Collection<Requirement<? extends Serializable>> getParameterRequirements() {
         return parameterRequirements.values();
     }
 }