-
Notifications
You must be signed in to change notification settings - Fork 10
Fix issue 97, 95, 93, 84, 39 #96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…> makeWithRoot to build even when dependencies are missing. Add test containers to test build and add integration tests. Signed-off-by: Rahul Krishna <i.m.ralk@gmail.com>
Signed-off-by: Rahul Krishna <i.m.ralk@gmail.com>
Signed-off-by: Rahul Krishna <i.m.ralk@gmail.com>
…> makeWithRoot to build even when dependencies are missing. Add Integration Tests. Signed-off-by: Rahul Krishna <i.m.ralk@gmail.com>
…> makeWithRoot to build even when dependencies are missing. Add Integration Tests. Signed-off-by: Rahul Krishna <i.m.ralk@gmail.com>
Signed-off-by: Rahul Krishna <i.m.ralk@gmail.com>
Signed-off-by: Rahul Krishna <i.m.ralk@gmail.com>
Signed-off-by: Rahul Krishna <i.m.ralk@gmail.com>
Signed-off-by: Rahul Krishna <i.m.ralk@gmail.com>
In reading #95, I noticed it says the problem occurs only when using |
Signed-off-by: Rahul Krishna <i.m.ralk@gmail.com>
…arch seeded at the JAVA_HOME directory to look for a folder. Signed-off-by: Rahul Krishna <i.m.ralk@gmail.com>
Yeah, either way if the dependencies are ignored WALA is looking for a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
The Problem: The error seems to come from a unique situation wherein,
mvnw
is corrupt and therefore the dependencies are not downloaded. Then, when we use analysis level 2, WALA is unable to resolve any super classes of the two servlet classes.The fix: First, we ensure that if
./mvnw
is corrupt, then ensure we usemvn
(which we weren't correctly doing); next, usemakeWithRoot(...)
to create WALA analysis scope which will assume all classes inherit fromjava.lang.Object
.This PR also creates a number of integration tests that uses TestContainers to emulate various usage scenarios of maven, gradle, etc. As requested in issue #84.
This PR also fixes issue #97 where we look recursively for
jmods
folder givenJAVA_HOME
: