Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: refactor SessionFilterTest by rector 0.18.6 #927

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

datamweb
Copy link
Collaborator

@datamweb datamweb commented Oct 24, 2023

Description
This PR is a refactor for testing using Rector.

See https://github.com/codeigniter4/shield/actions/runs/6641954393/job/18045603644

follow-up #929

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@datamweb datamweb changed the title chore: bump rector from 0.18.5 to 0.18.6 test: refactor SessionFilterTest by rector 0.18.6 Oct 25, 2023
@datamweb datamweb added refactor Pull requests that refactor code testing Pull requests that changes tests only labels Oct 25, 2023
@datamweb datamweb requested a review from kenjis October 25, 2023 17:17
@datamweb
Copy link
Collaborator Author

@kenjis @samsonasik thanks!

@datamweb datamweb merged commit e17a766 into codeigniter4:develop Oct 26, 2023
38 checks passed
@datamweb datamweb deleted the rector_upg branch October 26, 2023 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Pull requests that refactor code testing Pull requests that changes tests only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants