Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move config items #845

Merged
merged 9 commits into from
Sep 25, 2023
Merged

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Sep 19, 2023

Needs #843
Needs #847

Description

  • remove Config\AuthSession. Session Auth is the base authentication of Shield, so there is no need to separate a config file for it.
  • move items to Config\AuthToken. Config items for Token Auth should be put in it.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added breaking change Pull requests that may break existing functionalities refactor Pull requests that refactor code labels Sep 19, 2023
@kenjis kenjis marked this pull request as draft September 19, 2023 07:38
@kenjis kenjis marked this pull request as ready for review September 19, 2023 21:10
@kenjis kenjis marked this pull request as draft September 23, 2023 01:19
@kenjis kenjis marked this pull request as ready for review September 24, 2023 03:43
@datamweb datamweb merged commit 6189f9e into codeigniter4:develop Sep 25, 2023
@datamweb
Copy link
Collaborator

@kenjis Thank you!

@kenjis kenjis deleted the move-config-items branch September 25, 2023 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Pull requests that may break existing functionalities refactor Pull requests that refactor code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants