Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: reorganize (part 1) #839

Merged
merged 18 commits into from
Sep 19, 2023
Merged

docs: reorganize (part 1) #839

merged 18 commits into from
Sep 19, 2023

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Sep 17, 2023 •
edited
Loading

Description
The current documentation is difficult to understand where it is written.

  • add Home content
  • split pages
  • categorize the pages
  • fix typos
screenshot 2023-09-17 17 54 02

Online demo: https://datamweb.github.io/shield/install/

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • User guide updated
  • [] Conforms to style guide

@kenjis kenjis marked this pull request as draft September 17, 2023 05:37
@kenjis kenjis added the documentation Improvements or additions to documentation label Sep 17, 2023
@kenjis kenjis marked this pull request as ready for review September 17, 2023 08:55
@kenjis kenjis changed the title docs: reorganize docs: reorganize (part 1) Sep 17, 2023
datamweb
datamweb approved these changes Sep 17, 2023
View reviewed changes
Copy link
Collaborator

@datamweb datamweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

docs/index.md Outdated Show resolved Hide resolved
datamweb
datamweb approved these changes Sep 17, 2023
View reviewed changes
Copy link
Collaborator

@datamweb datamweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kenjis
Copy link
Member Author

kenjis commented Sep 19, 2023

Rebased to resolve conflicts.

@kenjis kenjis merged commit fdd5bcb into codeigniter4:develop Sep 19, 2023
1 check passed
@kenjis kenjis deleted the docs-reorganize branch September 19, 2023 00:21
@kenjis kenjis mentioned this pull request Sep 19, 2023
Merged
2 tasks
@kenjis kenjis mentioned this pull request Oct 3, 2023
Merged
1 task
@kenjis kenjis added the enhancement New feature or request label Oct 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@datamweb datamweb datamweb approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kenjis @datamweb