-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: improve user experience in forms #801
Conversation
PHPUnit Tests NOT associated with this PR failed:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, I am against the views becoming crowded. The reason for this is that I believe that every website should have its own customized views, and it is usually easier to copy paste and edit simple files.
However, I understand what your goal is with this PR. So except for the one I mentioned, everything looks good.
Thanks for the screenshot.
I understand your concern but it may surprise you to know that some of the websites that use shield, use the auth views the same way it is. Currently, the views are built using bootstrap framework and a lot of websites use the same framework. So if there will be changes, it will be minimal. Do you remember someone suggested that dark mode feature should be added to the views #772 ? |
Yes, I know, probably we could have done much better in terms of education.
I was silent there too. Probably, if someone else had sent this PR, I would not have given these explanations. Anyway, there should be a difference between the answer to the user who has already been with the Shield and the new user who wants to be added recently. |
Co-authored-by: Pooya Parsa <pooya_parsa_dadashi@yahoo.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sammyskills thank you!
I get your point @datamweb. There are some suggestions that are totally out of the scope of shield, but, I also know that there are some that will serve as a foundation or example to any tweak that will be done by developers. As developers, I know it is sometimes hard to think about user experience, but, believe me, it is very vital. |
Co-authored-by: kenjis <kenji.uui@gmail.com>
Currently, when filling forms, there is no indication of the field being filled (or what is expected of the user) after a user has entered value in the input fields. If a user forgets what was in the placeholder before filling the form, s/he will need to delete the entire entry in the input to know what the field expects. See screenshot below:
This PR improves user experience by providing a floating label to indicate the field that is being filled. See screenshot below: