Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add redirect denied for filter #790

Merged
merged 10 commits into from
Oct 18, 2023
Merged

feat: add redirect denied for filter #790

merged 10 commits into from
Oct 18, 2023

Conversation

datamweb
Copy link
Collaborator

@datamweb datamweb added the enhancement New feature or request label Aug 16, 2023
kenjis
kenjis reviewed Aug 17, 2023
View reviewed changes
src/Config/Auth.php Outdated Show resolved Hide resolved
kenjis
kenjis reviewed Aug 17, 2023
View reviewed changes
src/Config/Auth.php Outdated Show resolved Hide resolved
kenjis
kenjis reviewed Aug 17, 2023
View reviewed changes
src/Config/Auth.php Outdated Show resolved Hide resolved
@datamweb datamweb marked this pull request as draft August 17, 2023 03:12
@datamweb datamweb added the breaking change Pull requests that may break existing functionalities label Aug 17, 2023
@datamweb
Copy link
Collaborator Author

Added how to upgrade and use config('Auth').

@datamweb datamweb marked this pull request as ready for review October 17, 2023 16:13
@datamweb datamweb requested a review from kenjis October 17, 2023 16:13
kenjis
kenjis reviewed Oct 18, 2023
View reviewed changes
UPGRADING.md Outdated Show resolved Hide resolved
kenjis
kenjis reviewed Oct 18, 2023
View reviewed changes
UPGRADING.md Outdated Show resolved Hide resolved
kenjis
kenjis reviewed Oct 18, 2023
View reviewed changes
UPGRADING.md Show resolved Hide resolved
kenjis
kenjis reviewed Oct 18, 2023
View reviewed changes
UPGRADING.md Outdated Show resolved Hide resolved
kenjis
kenjis reviewed Oct 18, 2023
View reviewed changes
src/Filters/GroupFilter.php Outdated Show resolved Hide resolved
kenjis
kenjis reviewed Oct 18, 2023
View reviewed changes
UPGRADING.md Outdated Show resolved Hide resolved
@datamweb @kenjis
docs: apply suggestions from code review
6d5683a 
Co-authored-by: kenjis <kenji.uui@gmail.com>
kenjis
kenjis reviewed Oct 18, 2023
View reviewed changes
UPGRADING.md Outdated Show resolved Hide resolved
@datamweb @kenjis
docs: use h3 for title
1546bec 
Co-authored-by: kenjis <kenji.uui@gmail.com>
kenjis
kenjis approved these changes Oct 18, 2023
View reviewed changes
Copy link
Member

@kenjis kenjis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks.

@datamweb datamweb merged commit 56ab89e into codeigniter4:develop Oct 18, 2023
31 of 32 checks passed
@datamweb datamweb deleted the feat-add-denied-for-filter branch October 18, 2023 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samsonasik samsonasik samsonasik left review comments

@kenjis kenjis kenjis approved these changes

Assignees
No one assigned
Labels
breaking change Pull requests that may break existing functionalities enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@datamweb @kenjis @samsonasik