-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add login link to magic link form view #730
feat: add login link to magic link form view #730
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@GeorgKott thank you for PR.
This issue has already been implemented in PR #394, only the test has not been added.
Can you do the same as PR #394 with the test?
And I edited your comment, why? you can read here.
I did the same as PR #394, exept changing "backToLogin" key to "usePassword". And add simple test. |
Yes, I mean using NOTE: The audience for your commit messages will be the codebase maintainers, any code reviewers, and debuggers trying to figure out when a bug might have been introduced. There are some references for writing good commit messages: more info see here. |
Thank you for links! I did some changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@GeorgKott thank you!
LGTM.
@GeorgKott Thank you! |
Supersedes #394
Closes #299
Thank you