-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Italian Translation #530
Italian Translation #530
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Che bello!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the duplicate keys (see Rector results): throttled, successLogout.
Thanks @MGatner fixed |
@virdb, thanks, For this you need to create a file in path <?php
declare(strict_types=1);
namespace Tests\Language;
/**
* @internal
*/
final class ItalianTranslationTest extends AbstractTranslationTestCase
{
} Then add the following option in file - // ItalianTranslationTest::class => 'it',
+ ItalianTranslationTest::class => 'it',
Do you need more explanation? |
Hi @datamweb, sorry I missed the request for this. BR |
Well, we have a few errors. |
Hi, I added the translations for those strings, but usually are used in the English form also in Italian. |
@virdb If that is the case, please edit your ItalianTranslationTest and add the exclusions list as an array: final class ItalianTranslationTest extends AbstractTranslationTestCase
{
protected array $excludedLocaleKeyTranslations = [
// keys here, like Auth.login
];
}
` |
Co-authored-by: Pooya Parsa Dadashi <pooya_parsa_dadashi@yahoo.com>
added excluded keys
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Chi la dura la vince.
PHPStan is still failing:
|
All tests passed. And waiting for the review. |
Added Italian translation.
Supersedes #529