Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: [Authorizable Trait] move $matrix outside foreach loop #1178

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

christianberkman
Copy link
Contributor

Description
$matrix = setting('AuthGroups.matrix'); can be moved out of the foreach ($permissions as $permission) loop since the value is the same for every iteration.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@datamweb datamweb added tests needed Pull requests that need tests refactor Pull requests that refactor code labels Aug 22, 2024
Copy link
Collaborator

@datamweb datamweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@datamweb datamweb removed the tests needed Pull requests that need tests label Aug 22, 2024
Copy link
Member

@kenjis kenjis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kenjis kenjis merged commit 304795a into codeigniter4:develop Aug 23, 2024
36 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Pull requests that refactor code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants