Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: cannot override emailer() function #1174

Merged
merged 1 commit into from
Aug 20, 2024
Merged

fix: cannot override emailer() function #1174

merged 1 commit into from
Aug 20, 2024

Conversation

FrancoisChaumont
Copy link
Contributor

Description
Fixes #1173

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@datamweb datamweb added the GPG-Signing needed Pull requests that need GPG-Signing label Aug 19, 2024
@datamweb datamweb changed the title replaced defined() by function_exists() fix: replaced defined() by function_exists() Aug 19, 2024
@datamweb
Copy link
Collaborator

Please sign all your commits.

See:
#672 (comment)

More Info:
https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/pull_request.md#signing

@datamweb datamweb added the bug Something isn't working label Aug 19, 2024
@FrancoisChaumont
Copy link
Contributor Author

Please sign all your commits.

See: #672 (comment)

More Info: https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/pull_request.md#signing

Sorry about that. It should be signed now

@datamweb
Copy link
Collaborator

It should be signed now

No, see:
#672 (comment)

@datamweb datamweb removed the GPG-Signing needed Pull requests that need GPG-Signing label Aug 19, 2024
@FrancoisChaumont
Copy link
Contributor Author

It should be signed now

No, see: #672 (comment)

Sorry, first time signing commits. Hopefully it is signed now

datamweb
datamweb approved these changes Aug 19, 2024
View reviewed changes
Copy link
Collaborator

@datamweb datamweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, first time signing commits. Hopefully it is signed now

No problem at all! Signing commits for the first time can be a bit tricky. Your commit are now signed, you’re all set!
And thanks again for your contribution—it's much appreciated!

LGTM!

@FrancoisChaumont
Copy link
Contributor Author

Sorry, first time signing commits. Hopefully it is signed now

No problem at all! Signing commits for the first time can be a bit tricky. Your commit are now signed, you’re all set! And thanks again for your contribution—it's much appreciated!

LGTM!

Awesome! Keep up the good work. Thank you

@datamweb datamweb reopened this Aug 19, 2024
@datamweb
Copy link
Collaborator

@FrancoisChaumont Please do not close PR. Wait for your code to be reviewed and merged by other team members.

@FrancoisChaumont
Copy link
Contributor Author

@FrancoisChaumont Please do not close PR. Wait for your code to be reviewed and merged by other team members.

Apologies. Ok

@kenjis kenjis changed the title fix: replaced defined() by function_exists() fix: cannot override emailer() function Aug 20, 2024
@kenjis kenjis merged commit 136e0c5 into codeigniter4:develop Aug 20, 2024
64 checks passed
@kenjis
Copy link
Member

kenjis commented Aug 20, 2024

@FrancoisChaumont Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@datamweb datamweb datamweb approved these changes

@kenjis kenjis kenjis approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: defined() used for function
3 participants
@FrancoisChaumont @datamweb @kenjis