-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: chain
filter does not update last_active
#1160
fix: chain
filter does not update last_active
#1160
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This feature only works when session/tokens filter is active.
Lines 157 to 167 in 0ead2a1
/** | |
* -------------------------------------------------------------------- | |
* Record Last Active Date | |
* -------------------------------------------------------------------- | |
* If true, will always update the `last_active` datetime for the | |
* logged-in user on every page request. | |
* This feature only works when session/tokens filter is active. | |
* | |
* @see https://codeigniter4.github.io/shield/quick_start_guide/using_session_auth/#protecting-pages for set filters. | |
*/ | |
public bool $recordActiveDate = true; |
|
27cfb36
to
566ef50
Compare
@datamweb The option is used in HmacAuth, JWTAuth, SessionAuth, and TokenAuth filters. Updated the comment for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description
Fixes #1154
The
chain
filter also should updatelast_active
.Checklist: