feat: [Magic Link Login] add placeholder to invalidEmail to return user email.

[warcooft]

Description
This pull request improves existing translations by returning the user's email if the corresponding email is not found. This update aims to make communication more engaging and user-friendly. By returning the email value in the error message, it will help users to confirm and correct the email sent because in general users often make typos.

Preview

Checklist:

• Securely signed commits
• Component(s) with PHPDoc blocks, only if necessary or adds value
• Unit testing, with >80% coverage
• User guide updated
• Conforms to style guide

[kenjis]

Please fix errors in GitHub Action checks, and add test code.
Reference: https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/pull_request.md

[warcooft]

@kenjis all language files need to be updated but I don't understand other languages. Should I use english for other files as default language to be translated later by respective authors?

[kenjis]

@warcooft
See 2dc1252#diff-2b85118f8a629f90163570fda562d9379b8ee25dafc16e8748e7eb892884ddd2

[warcooft]

Ahh, OK. I will update later.

[kenjis]

Escape this:

shield/src/Views/magic_link_form.php

Line 22 in 1829443

<?= session('errors') ?>

[warcooft]

I'm in a meeting now, I'll update again later.

[kenjis]

Escape this, too.

shield/src/Views/magic_link_form.php

Line 22 in 1829443

<?= session('errors') ?>

[kenjis]

@warcooft We don't use merge commits in PR branches. See GitHub Actions.
Can you remove it?
How to update your PR branch: https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/workflow.md#updating-your-branch

[warcooft]

ups, my bad, okay I'll rebase.

[warcooft]

It seems to be fine now, please check it.

[warcooft]

Where can I find that key in the test case?

19) Tests\Language\UkrainianTranslationTest::testAllIncludedLanguageKeysAreTranslated with data set "uk" ('uk')
Failed asserting that the translated language key "Auth.invalidEmail" in "uk" locale differs from the original keys in the main repository.
Failed asserting that an array is empty.

[kenjis]

Where can I find that key in the test case?

See https://github.com/codeigniter4/shield/pull/1145/files#diff-12beddb17619112c65bd21202ce1fe8bcd291beb594aa101c90f09b174289fc7R28

Failed asserting that the translated language key "Auth.invalidEmail" in "uk" locale differs from the original keys in the main repository.

It is difficult to understand, but it tells "Auth.invalidEmail" in "uk" must be different from en.

[warcooft]

I see, I forgot to add something.

[warcooft]

done

[kenjis]

LGTM!

[datamweb]

@warcooft thank you!

Sorry for the delay.