-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Change session manipulation methods from private
to protected
#1113
Conversation
This Session class is already very long, and would violate the SRP. |
The methods related to the user session will give us about 50 lines of code. I don't see the point of moving them to a separate class - especially if they are to remain non-public. |
The session data manipulation is needed only for the Session authenticator. By the way, is this an enhancement or a bug fix? |
I would say this is an enhancement. |
private
to protected
private
to protected
Then it should be released as v1.1.0. |
Okay. I'm not familiar with the Shield release cycle, so it's up to you when you'd like to merge this. |
Description
This PR changes the session manipulation methods from
private
toprotected
, so we can use them if we extend theAuthentication\Authenticators\Session
class.Reference: #1111
Checklist: