Skip to content

lang: [cs] Add Czech Translation #1012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

MichalSkoula
Copy link
Contributor

@MichalSkoula MichalSkoula commented Feb 2, 2024

I have added Czech translation for shield + fixed Slovak translation.

@MichalSkoula MichalSkoula changed the title Add Czech Translation lang: [cs] Add Czech Translation Feb 2, 2024
Copy link
Member

@kenjis kenjis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't include [sk] changes in a [cs] PR.

One thing at a time: A pull request should only contain one change. That does not mean only one commit, but one change - however many commits it took.
https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/pull_request.md#branching

@MichalSkoula
Copy link
Contributor Author

Ok I have reverted Slovak translation with a new commit.

@datamweb
Copy link
Collaborator

datamweb commented Feb 2, 2024

Hi,
Thank you for contributing!
Please see #235 (comment)

@MichalSkoula
Copy link
Contributor Author

ok done :)

MichalSkoula and others added 2 commits February 2, 2024 13:49
Co-authored-by: Pooya Parsa <pooya_parsa_dadashi@yahoo.com>
Co-authored-by: Pooya Parsa <pooya_parsa_dadashi@yahoo.com>
@datamweb datamweb added the lang Languages file label Feb 2, 2024
Copy link
Collaborator

@datamweb datamweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
thank you!

@datamweb datamweb added the GPG-Signing needed Pull requests that need GPG-Signing label Feb 3, 2024
@datamweb
Copy link
Collaborator

datamweb commented Feb 3, 2024

@MichalSkoula See #672 (comment)

@MichalSkoula
Copy link
Contributor Author

@MichalSkoula See #672 (comment)

Should I create a new PR?

@datamweb
Copy link
Collaborator

datamweb commented Feb 3, 2024

How to sign past commits is explained here, but feel free to do so if you're comfortable creating new PRs.

@MichalSkoula
Copy link
Contributor Author

Creating a new PR is easier for me. I have done so - #1015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GPG-Signing needed Pull requests that need GPG-Signing lang Languages file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants