Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: controller run even if $allowMagicLinkLogins is false #777

Closed
mshannaq opened this issue Aug 9, 2023 · 2 comments · Fixed by #778
Closed

Bug: controller run even if $allowMagicLinkLogins is false #777

mshannaq opened this issue Aug 9, 2023 · 2 comments · Fixed by #778
Assignees
Labels
bug Something isn't working

Comments

@mshannaq
Copy link
Contributor

mshannaq commented Aug 9, 2023

PHP Version

8.2.7

CodeIgniter4 Version

4.3.7

Shield Version

dev-develop

Which operating systems have you tested for this bug?

Linux

Which server did you use?

apache

Database

MySQl 8.0

Did you customize Shield?

if you use direct link
http://localhost/login/magic-link
even if $allowMagicLinkLogins set to false in Config/Auth.php
the view form magic-link-login '\CodeIgniter\Shield\Views\magic_link_form' will be shown. and if the form submitted the email will be sent

What happened?

disable magic link $allowMagicLinkLogins = false in Config/Auth.php
goto http://localhost/login/magic-link directly

Steps to Reproduce

disable magic link $allowMagicLinkLogins = false in Config/Auth.php
goto http://localhost/login/magic-link directly

Expected Output

not to show the form while allowMagicLinkLogins = false

Anything else?

No response

@datamweb
Copy link
Collaborator

datamweb commented Aug 9, 2023

Hello @mshannaq , thanks for your report.
I sent PR #778.

@kenjis
Copy link
Member

kenjis commented Aug 10, 2023

@mshannaq Thank you for reporting. I've confirmed the bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants