Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev: Extend Actions to allow custom rendering methods. #555

Closed
lonnieezell opened this issue Dec 12, 2022 · 0 comments · Fixed by #565
Closed

Dev: Extend Actions to allow custom rendering methods. #555

lonnieezell opened this issue Dec 12, 2022 · 0 comments · Fixed by #565
Labels
enhancement New feature or request

Comments

@lonnieezell
Copy link
Member

Currently, the Email2FA and EmailActivation methods use the built-in view() method to display a view. This works great unless someone has provided an extended View layer. For example, in Bonfire we have a theme system that uses $this->render() in the controllers to integrate with the theme system. This would require duplicating the actions into the developers code when all they want to do is change the render method. That leads to maintenance headaches.

I propose we add a renderView() method to both of the Actions so that all a developer has to do is extend the Action class and override that one method, keeping all of the other logic intact.

@lonnieezell lonnieezell added enhancement New feature or request help wanted Extra attention is needed labels Dec 12, 2022
@lonnieezell lonnieezell changed the title Extend Actions to allow custom rendering methods. Dev: Extend Actions to allow custom rendering methods. Dec 12, 2022
@lonnieezell lonnieezell removed the help wanted Extra attention is needed label Dec 12, 2022
kenjis added a commit that referenced this issue Dec 20, 2022
dev: Allow easier overriding of views in developer applications. Fixes #555
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant