From 1424bdd72d72592f142f7782775c3f0ba45d10cb Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Tue, 5 Nov 2024 14:41:56 +0000 Subject: [PATCH 1/2] chore(deps-dev): update rector/rector requirement from 1.2.8 to 1.2.9 Updates the requirements on [rector/rector](https://github.com/rectorphp/rector) to permit the latest version. - [Release notes](https://github.com/rectorphp/rector/releases) - [Commits](https://github.com/rectorphp/rector/compare/1.2.8...1.2.9) --- updated-dependencies: - dependency-name: rector/rector dependency-type: direct:development ... Signed-off-by: dependabot[bot] --- composer.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/composer.json b/composer.json index 6967d8877..d98dacaaa 100644 --- a/composer.json +++ b/composer.json @@ -39,7 +39,7 @@ "phpstan/extension-installer": "^1.3", "phpstan/phpstan-strict-rules": "^1.5", "phpunit/phpunit": "^9.6", - "rector/rector": "1.2.8" + "rector/rector": "1.2.9" }, "provide": { "codeigniter4/authentication-implementation": "1.0" From 6abf48f2c8a3a1b23ef5fcc11d5cc4fc5897c64d Mon Sep 17 00:00:00 2001 From: Abdul Malik Ikhsan Date: Tue, 5 Nov 2024 21:57:05 +0700 Subject: [PATCH 2/2] skip NarrowUnusedSetUpDefinedPropertyRector as still buggy Signed-off-by: Abdul Malik Ikhsan --- rector.php | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/rector.php b/rector.php index 8185f4a71..d9e3e5d70 100644 --- a/rector.php +++ b/rector.php @@ -45,6 +45,7 @@ use Rector\Php55\Rector\String_\StringClassNameToClassConstantRector; use Rector\Php73\Rector\FuncCall\StringifyStrNeedlesRector; use Rector\PHPUnit\AnnotationsToAttributes\Rector\Class_\AnnotationWithValueToAttributeRector; +use Rector\PHPUnit\CodeQuality\Rector\Class_\NarrowUnusedSetUpDefinedPropertyRector; use Rector\PHPUnit\CodeQuality\Rector\Class_\YieldDataProviderRector; use Rector\PHPUnit\Set\PHPUnitSetList; use Rector\Privatization\Rector\Property\PrivatizeFinalClassPropertyRector; @@ -131,6 +132,9 @@ // To check old Email Config file __DIR__ . '/src/Commands/Setup.php', ], + + // buggy with default value + NarrowUnusedSetUpDefinedPropertyRector::class, ]); // auto import fully qualified class names