refactor: replace empty()

Author: kenjis

phpstan-baseline.php

@@ -1,16 +1,6 @@
 <?php declare(strict_types = 1);
 
 $ignoreErrors = [];
-$ignoreErrors[] = [
-	'message' => '#^Construct empty\\(\\) is not allowed\\. Use more strict comparison\\.$#',
-	'count' => 1,
-	'path' => __DIR__ . '/src/Auth.php',
-];
-$ignoreErrors[] = [
-	'message' => '#^Only booleans are allowed in a ternary operator condition, CodeIgniter\\\\Shield\\\\Entities\\\\User\\|null given\\.$#',
-	'count' => 1,
-	'path' => __DIR__ . '/src/Auth.php',
-];
 $ignoreErrors[] = [
 	'message' => '#^Call to deprecated function random_string\\(\\)\\:
 The type \'basic\', \'md5\', and \'sha1\' are deprecated\\. They are not cryptographically secure\\.$#',

src/Auth.php

@@ -67,7 +67,7 @@ protected function ensureAuthentication(): void
      */
     public function setAuthenticator(?string $alias = null): self
     {
-        if (! empty($alias)) {
+        if ($alias !== null) {
             $this->alias = $alias;
         }
 
@@ -102,9 +102,9 @@ public function user(): ?User
      */
     public function id()
     {
-        return ($user = $this->user())
-            ? $user->id
-            : null;
+        $user = $this->user();
+
+        return ($user !== null) ? $user->id : null;
     }
 
     public function authenticate(array $credentials): Result