Skip to content

docs: Fix variable name according to the example #9485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 12, 2025

Conversation

Elias-Black
Copy link
Contributor

No description provided.

Copy link

mergeable bot commented Mar 10, 2025

Hi there, Elias-Black! 👋

Thank you for sending this PR!

We expect the following in all Pull Requests (PRs).

Important

We expect all code changes or bug-fixes to be accompanied by one or more tests added to our test suite to prove the code works.

If pull requests do not comply with the above, they will likely be closed. Since we are a team of volunteers, we don't have any more time to work
on the framework than you do. Please make it as painless for your contributions to be included as possible.

See https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/pull_request.md

Sincerely, the mergeable bot 🤖

@Elias-Black Elias-Black changed the title Fix variable name according to the example fix: Fix variable name according to the example Mar 10, 2025
@neznaika0
Copy link
Contributor

Good Point, the correction is unqualified.

public function findColumn(string $columnName)

Do you want to find other errors that don't match the code? 😄 Example, Forge::dropColumn() Forge::dropTable() in forge.rst: php:method:: dropTable($table_name[, $if_exists = false])

@michalsn michalsn changed the title fix: Fix variable name according to the example docs: Fix variable name according to the example Mar 12, 2025
@michalsn michalsn added the documentation Pull requests for documentation only label Mar 12, 2025
@michalsn michalsn merged commit 99be151 into codeigniter4:develop Mar 12, 2025
4 checks passed
@michalsn
Copy link
Member

@Elias-Black Thank you and congratulations on your first PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Pull requests for documentation only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants