Skip to content

docs: add missing app/Config/App.php in upgrade_447.rst #8691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 31, 2024
Merged

docs: add missing app/Config/App.php in upgrade_447.rst #8691

merged 1 commit into from
Mar 31, 2024

Conversation

mullernato
Copy link
Contributor

@mullernato mullernato commented Mar 31, 2024 •
edited by kenjis
Loading

Description
added this line to changed files upgrade

  • app/Config/App.php

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@mullernato
Update upgrade_447.rst
dc7e86c 
added to changed files
- app/Config/App.php
@kenjis kenjis changed the title docs Update upgrade_447.rst docs: add missing app/Config/App.php in upgrade_447.rst Mar 31, 2024
@kenjis kenjis added the documentation Pull requests for documentation only label Mar 31, 2024
kenjis
kenjis approved these changes Mar 31, 2024
View reviewed changes
Copy link
Member

@kenjis kenjis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it must be in there.
Thank you!

@kenjis kenjis merged commit c6b7505 into codeigniter4:develop Mar 31, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kenjis kenjis kenjis approved these changes

Assignees
No one assigned
Labels
documentation Pull requests for documentation only
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mullernato @kenjis