Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove deprecated methods in Model #8032

Merged
merged 4 commits into from
Oct 13, 2023
Merged

refactor: remove deprecated methods in Model #8032

merged 4 commits into from
Oct 13, 2023

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Oct 11, 2023 •
edited
Loading

Description
Explain what you have changed, and why.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added refactor Pull requests that refactor code breaking change Pull requests that may break existing functionalities 4.5 labels Oct 11, 2023
@kenjis kenjis marked this pull request as draft October 11, 2023 11:27
@kenjis kenjis marked this pull request as ready for review October 12, 2023 01:43
@github-actions github-actions bot added the stale Pull requests with conflicts label Oct 12, 2023
@github-actions
Copy link

👋 Hi, @kenjis!

We detected conflicts in your PR against the base branch 🙊
You may want to sync 🔄 your branch with upstream!

Ref: Syncing Your Branch

MGatner
MGatner approved these changes Oct 12, 2023
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awaiting conflict resolution.

@kenjis kenjis removed the stale Pull requests with conflicts label Oct 13, 2023
@kenjis kenjis merged commit 2c48d36 into codeigniter4:4.5 Oct 13, 2023
54 checks passed
@kenjis kenjis deleted the remove-deprecated-in-model branch October 13, 2023 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MGatner MGatner MGatner approved these changes

Assignees
No one assigned
Labels
4.5 breaking change Pull requests that may break existing functionalities refactor Pull requests that refactor code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kenjis @MGatner