New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: if condition in OCI8/Connection.php #7994

Merged

kenjis merged 1 commit into codeigniter4:develop from kenjis:refactor-OCI8-Connection-if

Oct 3, 2023

Member

kenjis commented Sep 30, 2023

Description
To fix PHPStan error.
See https://github.com/codeigniter4/CodeIgniter4/actions/runs/6358613550/job/17271052582

Checklist:

Securely signed commits
[] Component(s) with PHPDoc blocks, only if necessary or adds value
[] Unit testing, with >80% coverage
[] User guide updated
Conforms to style guide


          refactor: if condition

c3c170e

kenjis added the refactor label

neznaika0 approved these changes

View reviewed changes

kenjis merged commit e67b42a into codeigniter4:develop

63 checks passed

kenjis deleted the refactor-OCI8-Connection-if branch

October 3, 2023 05:27

Member Author

kenjis commented Oct 3, 2023

@neznaika0 Thank you for review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels