-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: incorrect return type for Model::objectToRawArray() #7986
fix: incorrect return type for Model::objectToRawArray() #7986
Conversation
35d1531
to
199f70c
Compare
Co-authored-by: MGatner <mgatner@icloud.com>
b9de0fa
to
952aabd
Compare
Rebased to resolve conflicts. |
* @return array Array with raw values. | ||
* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* @return array Array with raw values. | |
* |
Also here.
* @return array Array with raw values. | ||
* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* @return array Array with raw values. | |
* |
I think the description here is not necessary, since the method has a specific return type.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The intent of the comment is to indicate that the values are raw values.
However, I doubt that most people correctly understand what raw values are.
Description
Checklist: