Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update psr/log to v2 and fix Logger interface #7967

Merged
merged 7 commits into from
Sep 28, 2023
Merged

fix: update psr/log to v2 and fix Logger interface #7967

merged 7 commits into from
Sep 28, 2023

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Sep 24, 2023 •
edited
Loading

Description
See #4936

php-coveralls/php-coveralls requires psr/log v1 or v2.
So we cannot upgrade to v3 now.

  • update psr/logto v2.
  • fix incorrect Logger interface

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added breaking change Pull requests that may break existing functionalities 4.5 bug Verified issues on the current code behavior or pull requests that will fix them labels Sep 24, 2023
@kenjis kenjis changed the title chore: update psr/log to v2 chore: update psr/log to v2 and fix Logger interface Sep 24, 2023
@kenjis kenjis changed the title chore: update psr/log to v2 and fix Logger interface fix: update psr/log to v2 and fix Logger interface Sep 24, 2023
@kenjis
Copy link
Member Author

kenjis commented Sep 25, 2023

Added the docs.

@kenjis kenjis mentioned this pull request Sep 25, 2023
Closed
4 tasks
@MGatner
Copy link
Member

MGatner commented Sep 27, 2023

php-coveralls/php-coveralls#359

@kenjis kenjis merged commit fb30ae2 into codeigniter4:4.5 Sep 28, 2023
56 checks passed
@kenjis kenjis deleted the psr-log-v2 branch September 28, 2023 00:19
@kenjis kenjis mentioned this pull request Sep 28, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MGatner MGatner MGatner approved these changes

@paulbalandan paulbalandan paulbalandan approved these changes

Assignees
No one assigned
Labels
4.5 breaking change Pull requests that may break existing functionalities bug Verified issues on the current code behavior or pull requests that will fix them
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kenjis @MGatner @paulbalandan