-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add environment spark command #4734
Add environment spark command #4734
Conversation
4670796
to
76fe1c7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this, very helpful and easy to use. This commits us to a baseline env that is entirely comments - this is currently the case and I believe this was always the intention, but is there some place we could make note of this "for future generations"? (i.e. for me when I forget next week) Maybe somewhere in contributing/ we need some more "policies" or something?
I'm not sure I get what you mean. Are you referring to the env file? |
Right, since this command will publish the template (env) to a live .env we need to be certain that our repo version of the template is all comments, otherwise using this command could cause accidental environment settings. I was looking for ideas of where we could track this - maybe add it to https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/internals.rst ? |
Understood. Will look into this. |
06e4bd9
to
2e96bde
Compare
Thanks! Looks great. Re-approve! |
Description
Adds a spark command to show/change the current environment. Changes will be effected in the next script execution.
Checklist: