Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add environment spark command #4734

Merged
merged 3 commits into from
May 26, 2021

Conversation

paulbalandan
Copy link
Member

Description
Adds a spark command to show/change the current environment. Changes will be effected in the next script execution.

$ php spark env
# Your current environment is set as testing.

$ php spark env development
# Environment successfully changed to "development".

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this, very helpful and easy to use. This commits us to a baseline env that is entirely comments - this is currently the case and I believe this was always the intention, but is there some place we could make note of this "for future generations"? (i.e. for me when I forget next week) Maybe somewhere in contributing/ we need some more "policies" or something?

@paulbalandan
Copy link
Member Author

I like this, very helpful and easy to use. This commits us to a baseline env that is entirely comments - this is currently the case and I believe this was always the intention, but is there some place we could make note of this "for future generations"? (i.e. for me when I forget next week) Maybe somewhere in contributing/ we need some more "policies" or something?

I'm not sure I get what you mean. Are you referring to the env file?

@MGatner
Copy link
Member

MGatner commented May 25, 2021

Right, since this command will publish the template (env) to a live .env we need to be certain that our repo version of the template is all comments, otherwise using this command could cause accidental environment settings.

I was looking for ideas of where we could track this - maybe add it to https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/internals.rst ?

@paulbalandan
Copy link
Member Author

Understood. Will look into this.

@MGatner
Copy link
Member

MGatner commented May 26, 2021

Thanks! Looks great. Re-approve!

@paulbalandan paulbalandan merged commit 1c4872c into codeigniter4:develop May 26, 2021
@paulbalandan paulbalandan deleted the env-spark-command branch May 26, 2021 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants