Clearing up confusion with TLS and SSL in Email Library #3430
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalsn
requested changes
Jul 31, 2020
|
Good changes! Thank you for working on it. |
|
Very nice, thanks! |
kenjis
changed the title
This was referenced May 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fixes #3429
Making sure connection for email submissions to port 465 is always using implicit TLS as per RFC8314.
Updating docs to describe the differences between port 465 and 587 and why/when STARTTLS is required and the setting
$SMTPCrypto.Current implementation only enables TLSv1.0 for the upgrade after STARTTLS, this PR enables versions 1.0, 1.1 and 1.2.
Checklist: