Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: [QueryBuilder] BaseBuilder::compileFinalQuery() has hard coded Query class #4332

Open
kenjis opened this issue Feb 24, 2021 · 0 comments
Open

Bug: [QueryBuilder] BaseBuilder::compileFinalQuery() has hard coded Query class #4332

kenjis opened this issue Feb 24, 2021 · 0 comments
Labels
bug Verified issues on the current code behavior or pull requests that will fix them database Issues or pull requests that affect the database layer

Comments

@kenjis
Copy link
Member

kenjis commented Feb 24, 2021 •
edited
Loading

Describe the bug
This may be not a bug.
But Query class may be DBMS-specific, it is better not to hard code Query class.

CodeIgniter4/system/Database/BaseBuilder.php

Line 1850 in 42f6667

$query = new Query($this->db);

See #4176 (comment) and #4176 (comment).

CodeIgniter 4 version
develop branch.

Affected module(s)
Database

Expected behavior, and steps to reproduce if appropriate
The DBMS-specific Query class is used.
@kenjis kenjis added the bug Verified issues on the current code behavior or pull requests that will fix them label Feb 24, 2021
@MGatner MGatner added the database Issues or pull requests that affect the database layer label May 18, 2021
@kenjis kenjis changed the title Bug: BaseBuilder::compileFinalQuery() has hard coded Query class Bug: [QueryBuilder] BaseBuilder::compileFinalQuery() has hard coded Query class Apr 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Verified issues on the current code behavior or pull requests that will fix them database Issues or pull requests that affect the database layer
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kenjis @MGatner