Skip to content

Commit a50847d

Browse files
author
bentmann
committed
o Fixed unit test
1 parent 6a74658 commit a50847d

File tree

1 file changed

+8
-14
lines changed

1 file changed

+8
-14
lines changed

src/test/java/org/codehaus/plexus/util/FileUtilsTest.java

Lines changed: 8 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -981,23 +981,17 @@ public void testFilteredWithoutFilterAndOlderFileAndOverwrite()
981981

982982
}
983983

984-
/**
985-
* TEST FAILS ON WINDOWS.
986-
*
987-
* Failing to specify an encoding means the default platform encoding, which
988-
* varies from machine to machine. There is no guarantee that what this
989-
* creates is usable.
990-
*
991-
* This test should be deleted.
992-
*
993-
* @throws IOException
994-
*/
995-
public void disabledTestFileRead() throws IOException
984+
public void testFileRead() throws IOException
996985
{
997986
File testFile = new File( getTestDirectory(), "testFileRead.txt" );
998987
String testFileName = testFile.getAbsolutePath();
999-
// unicode escaped Japanese hiragana, "aiueo" + Umlaut a
1000-
String testString = "\u3042\u3044\u3046\u3048\u304a\u00e4";
988+
/*
989+
* NOTE: The method under test uses the JVM's default encoding which by its nature varies from machine to
990+
* machine. As a consequence, we cannot know in advance which characters are supported by the effective encoding
991+
* of the test runner. Therefore this test must be restricted to ASCII characters which are reasonably safe to
992+
* survive the roundtrip test.
993+
*/
994+
String testString = "Only US-ASCII characters here, see comment above!";
1001995
Writer writer = null;
1002996
try
1003997
{

0 commit comments

Comments
 (0)