Eclipse compiler: close the StandardJavaFileManager (#103)

tomaswolf · web-flow · commit 2a348f778982 · 2020-08-25T09:13:34.000+10:00
Compare #98.
diff --git a/plexus-compilers/plexus-compiler-eclipse/src/main/java/org/codehaus/plexus/compiler/eclipse/EclipseJavaCompiler.java b/plexus-compilers/plexus-compiler-eclipse/src/main/java/org/codehaus/plexus/compiler/eclipse/EclipseJavaCompiler.java
@@ -400,19 +400,16 @@ public void report( Diagnostic<? extends JavaFileObject> diagnostic )
                 {
                     charset = Charset.defaultCharset();
                 }
-                StandardJavaFileManager manager =
-                    compiler.getStandardFileManager( messageCollector, defaultLocale, charset );
-
                 if ( getLogger().isDebugEnabled() )
                 {
                     getLogger().debug( "ecj: using character set " + charset.displayName() );
                     getLogger().debug( "ecj command line: " + args );
                     getLogger().debug( "ecj input source files: " + allSources );
                 }
 
-                Iterable<? extends JavaFileObject> units = manager.getJavaFileObjectsFromStrings( allSources );
-                try
-                {
+                try ( StandardJavaFileManager manager =
+                    compiler.getStandardFileManager( messageCollector, defaultLocale, charset ) ) {
+                    Iterable<? extends JavaFileObject> units = manager.getJavaFileObjectsFromStrings( allSources );
                     success = Boolean.TRUE.equals(
                         compiler.getTask( devNull, manager, messageCollector, args, null, units ).call() );
                 }

Original file line number	Diff line number	Diff line change
`@@ -400,19 +400,16 @@ public void report( Diagnostic<? extends JavaFileObject> diagnostic )`
`400`	`400`	`{`
`401`	`401`	`charset = Charset.defaultCharset();`
`402`	`402`	`}`
`403`		`- StandardJavaFileManager manager =`
`404`		`- compiler.getStandardFileManager( messageCollector, defaultLocale, charset );`
`405`		`-`
`406`	`403`	`if ( getLogger().isDebugEnabled() )`
`407`	`404`	`{`
`408`	`405`	`getLogger().debug( "ecj: using character set " + charset.displayName() );`
`409`	`406`	`getLogger().debug( "ecj command line: " + args );`
`410`	`407`	`getLogger().debug( "ecj input source files: " + allSources );`
`411`	`408`	`}`
`412`	`409`
`413`		`- Iterable<? extends JavaFileObject> units = manager.getJavaFileObjectsFromStrings( allSources );`
`414`		`- try`
`415`		`- {`
	`410`	`+ try ( StandardJavaFileManager manager =`
	`411`	`+ compiler.getStandardFileManager( messageCollector, defaultLocale, charset ) ) {`
	`412`	`+ Iterable<? extends JavaFileObject> units = manager.getJavaFileObjectsFromStrings( allSources );`
`416`	`413`	`success = Boolean.TRUE.equals(`
`417`	`414`	`compiler.getTask( devNull, manager, messageCollector, args, null, units ).call() );`
`418`	`415`	`}`