Skip to content

Commit 3c05d7a

Browse files
Switch Plexus Annotation to JSR-330
1 parent bab14de commit 3c05d7a

File tree

35 files changed

+200
-106
lines changed

35 files changed

+200
-106
lines changed

modello-core/src/main/java/org/codehaus/modello/core/DefaultGeneratorPluginManager.java

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,21 +22,25 @@
2222
* SOFTWARE.
2323
*/
2424

25+
import javax.inject.Inject;
26+
import javax.inject.Named;
27+
import javax.inject.Singleton;
28+
2529
import java.util.Map;
2630

2731
import org.codehaus.modello.ModelloRuntimeException;
2832
import org.codehaus.modello.plugin.AbstractPluginManager;
2933
import org.codehaus.modello.plugin.ModelloGenerator;
30-
import org.codehaus.plexus.component.annotations.Component;
31-
import org.codehaus.plexus.component.annotations.Requirement;
3234

3335
/**
3436
* @author <a href="mailto:trygvis@inamo.no">Trygve Laugst&oslash;l</a>
3537
*/
36-
@Component(role = GeneratorPluginManager.class)
38+
@Named
39+
@Singleton
3740
public class DefaultGeneratorPluginManager extends AbstractPluginManager<ModelloGenerator>
3841
implements GeneratorPluginManager {
39-
@Requirement
42+
43+
@Inject
4044
private Map<String, ModelloGenerator> plugins;
4145

4246
public Map<String, ModelloGenerator> getPlugins() {

modello-core/src/main/java/org/codehaus/modello/core/DefaultMetadataPluginManager.java

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,21 +22,25 @@
2222
* SOFTWARE.
2323
*/
2424

25+
import javax.inject.Inject;
26+
import javax.inject.Named;
27+
import javax.inject.Singleton;
28+
2529
import java.util.Map;
2630

2731
import org.codehaus.modello.ModelloRuntimeException;
2832
import org.codehaus.modello.metadata.MetadataPlugin;
2933
import org.codehaus.modello.plugin.AbstractPluginManager;
30-
import org.codehaus.plexus.component.annotations.Component;
31-
import org.codehaus.plexus.component.annotations.Requirement;
3234

3335
/**
3436
* @author <a href="mailto:trygvis@inamo.no">Trygve Laugst&oslash;l</a>
3537
*/
36-
@Component(role = MetadataPluginManager.class)
38+
@Named
39+
@Singleton
3740
public class DefaultMetadataPluginManager extends AbstractPluginManager<MetadataPlugin>
3841
implements MetadataPluginManager {
39-
@Requirement
42+
43+
@Inject
4044
private Map<String, MetadataPlugin> plugins;
4145

4246
public Map<String, MetadataPlugin> getPlugins() {

modello-core/src/main/java/org/codehaus/modello/core/DefaultModelloCore.java

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,10 @@
2222
* SOFTWARE.
2323
*/
2424

25+
import javax.inject.Inject;
26+
import javax.inject.Named;
27+
import javax.inject.Singleton;
28+
2529
import java.io.File;
2630
import java.io.IOException;
2731
import java.io.Reader;
@@ -49,20 +53,20 @@
4953
import org.codehaus.modello.model.ModelInterface;
5054
import org.codehaus.modello.model.ModelValidationException;
5155
import org.codehaus.modello.plugin.ModelloGenerator;
52-
import org.codehaus.plexus.component.annotations.Component;
53-
import org.codehaus.plexus.component.annotations.Requirement;
5456
import org.codehaus.plexus.util.ReaderFactory;
5557

5658
/**
5759
* @author <a href="mailto:trygvis@inamo.no">Trygve Laugst&oslash;l</a>
5860
* @author <a href="mailto:evenisse@codehaus.org">Emmanuel Venisse</a>
5961
*/
60-
@Component(role = ModelloCore.class)
62+
@Named
63+
@Singleton
6164
public class DefaultModelloCore extends AbstractModelloCore {
62-
@Requirement
65+
66+
@Inject
6367
private MetadataPluginManager metadataPluginManager;
6468

65-
@Requirement
69+
@Inject
6670
private GeneratorPluginManager generatorPluginManager;
6771

6872
public MetadataPluginManager getMetadataPluginManager() {

modello-core/src/main/java/org/codehaus/modello/plugin/model/ModelMetadataPlugin.java

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,9 @@
2222
* SOFTWARE.
2323
*/
2424

25+
import javax.inject.Named;
26+
import javax.inject.Singleton;
27+
2528
import java.util.Map;
2629

2730
import org.codehaus.modello.metadata.AbstractMetadataPlugin;
@@ -36,12 +39,12 @@
3639
import org.codehaus.modello.model.ModelClass;
3740
import org.codehaus.modello.model.ModelField;
3841
import org.codehaus.modello.model.ModelInterface;
39-
import org.codehaus.plexus.component.annotations.Component;
4042

4143
/**
4244
* @author <a href="mailto:evenisse@codehaus.org">Emmanuel Venisse</a>
4345
*/
44-
@Component(role = MetadataPlugin.class, hint = "model")
46+
@Named("model")
47+
@Singleton
4548
public class ModelMetadataPlugin extends AbstractMetadataPlugin implements MetadataPlugin {
4649
public static final String ROOT_ELEMENT = "rootElement";
4750

modello-core/src/test/java/org/codehaus/modello/core/DefaultModelloCoreTest.java

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,8 @@
2323
*/
2424

2525
import org.codehaus.modello.ModelloRuntimeException;
26+
import org.codehaus.plexus.ContainerConfiguration;
27+
import org.codehaus.plexus.PlexusConstants;
2628
import org.codehaus.plexus.PlexusTestCase;
2729

2830
/**
@@ -70,4 +72,10 @@ public void testRecursion() throws Exception {
7072

7173
modello.loadModel(getTestFile("src/test/resources/models/recursion.mdo"));
7274
}
75+
76+
@Override
77+
protected void customizeContainerConfiguration(ContainerConfiguration configuration) {
78+
configuration.setAutoWiring(true);
79+
configuration.setClassPathScanning(PlexusConstants.SCANNING_INDEX);
80+
}
7381
}

modello-core/src/test/java/org/codehaus/modello/core/io/ModelReaderTest.java

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,8 @@
3131
import org.codehaus.modello.model.ModelField;
3232
import org.codehaus.modello.model.Version;
3333
import org.codehaus.modello.model.VersionRange;
34+
import org.codehaus.plexus.ContainerConfiguration;
35+
import org.codehaus.plexus.PlexusConstants;
3436
import org.codehaus.plexus.PlexusTestCase;
3537

3638
/**
@@ -164,4 +166,10 @@ private void assertGirlAge(Object ageObject) {
164166

165167
assertEquals("int", age.getType());
166168
}
169+
170+
@Override
171+
protected void customizeContainerConfiguration(ContainerConfiguration configuration) {
172+
configuration.setAutoWiring(true);
173+
configuration.setClassPathScanning(PlexusConstants.SCANNING_INDEX);
174+
}
167175
}

modello-plugins/modello-plugin-converters/src/main/java/org/codehaus/modello/plugin/converters/ConverterGenerator.java

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,9 @@
2222
* SOFTWARE.
2323
*/
2424

25+
import javax.inject.Named;
26+
import javax.inject.Singleton;
27+
2528
import java.io.IOException;
2629
import java.util.ArrayList;
2730
import java.util.Collections;
@@ -38,7 +41,6 @@
3841
import org.codehaus.modello.model.ModelField;
3942
import org.codehaus.modello.model.Version;
4043
import org.codehaus.modello.model.VersionDefinition;
41-
import org.codehaus.modello.plugin.ModelloGenerator;
4244
import org.codehaus.modello.plugin.java.AbstractJavaModelloGenerator;
4345
import org.codehaus.modello.plugin.java.javasource.JClass;
4446
import org.codehaus.modello.plugin.java.javasource.JInterface;
@@ -50,13 +52,13 @@
5052
import org.codehaus.modello.plugin.java.javasource.JType;
5153
import org.codehaus.modello.plugin.java.metadata.JavaClassMetadata;
5254
import org.codehaus.modello.plugin.java.metadata.JavaFieldMetadata;
53-
import org.codehaus.plexus.component.annotations.Component;
5455
import org.codehaus.plexus.util.IOUtil;
5556

5657
/**
5758
* Generate a basic conversion class between two versions of a model.
5859
*/
59-
@Component(role = ModelloGenerator.class, hint = "converters")
60+
@Named("converters")
61+
@Singleton
6062
public class ConverterGenerator extends AbstractJavaModelloGenerator {
6163
public void generate(Model model, Properties parameters) throws ModelloException {
6264
initialize(model, parameters);

modello-plugins/modello-plugin-dom4j/src/main/java/org/codehaus/modello/plugin/dom4j/Dom4jReaderGenerator.java

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,9 @@
2222
* SOFTWARE.
2323
*/
2424

25+
import javax.inject.Named;
26+
import javax.inject.Singleton;
27+
2528
import java.io.IOException;
2629
import java.util.List;
2730
import java.util.Properties;
@@ -32,7 +35,6 @@
3235
import org.codehaus.modello.model.ModelClass;
3336
import org.codehaus.modello.model.ModelDefault;
3437
import org.codehaus.modello.model.ModelField;
35-
import org.codehaus.modello.plugin.ModelloGenerator;
3638
import org.codehaus.modello.plugin.java.javasource.JClass;
3739
import org.codehaus.modello.plugin.java.javasource.JMethod;
3840
import org.codehaus.modello.plugin.java.javasource.JParameter;
@@ -42,7 +44,6 @@
4244
import org.codehaus.modello.plugins.xml.AbstractXmlJavaGenerator;
4345
import org.codehaus.modello.plugins.xml.metadata.XmlAssociationMetadata;
4446
import org.codehaus.modello.plugins.xml.metadata.XmlFieldMetadata;
45-
import org.codehaus.plexus.component.annotations.Component;
4647
import org.codehaus.plexus.util.StringUtils;
4748

4849
/**
@@ -51,7 +52,8 @@
5152
*
5253
* @author <a href="mailto:brett@codehaus.org">Brett Porter</a>
5354
*/
54-
@Component(role = ModelloGenerator.class, hint = "dom4j-reader")
55+
@Named("dom4j-reader")
56+
@Singleton
5557
public class Dom4jReaderGenerator extends AbstractXmlJavaGenerator {
5658

5759
private boolean requiresDomSupport;

modello-plugins/modello-plugin-dom4j/src/main/java/org/codehaus/modello/plugin/dom4j/Dom4jWriterGenerator.java

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,9 @@
2222
* SOFTWARE.
2323
*/
2424

25+
import javax.inject.Named;
26+
import javax.inject.Singleton;
27+
2528
import java.io.IOException;
2629
import java.util.List;
2730
import java.util.Properties;
@@ -32,7 +35,6 @@
3235
import org.codehaus.modello.model.ModelClass;
3336
import org.codehaus.modello.model.ModelDefault;
3437
import org.codehaus.modello.model.ModelField;
35-
import org.codehaus.modello.plugin.ModelloGenerator;
3638
import org.codehaus.modello.plugin.java.javasource.JClass;
3739
import org.codehaus.modello.plugin.java.javasource.JMethod;
3840
import org.codehaus.modello.plugin.java.javasource.JParameter;
@@ -44,7 +46,6 @@
4446
import org.codehaus.modello.plugins.xml.metadata.XmlAssociationMetadata;
4547
import org.codehaus.modello.plugins.xml.metadata.XmlFieldMetadata;
4648
import org.codehaus.modello.plugins.xml.metadata.XmlModelMetadata;
47-
import org.codehaus.plexus.component.annotations.Component;
4849

4950
/**
5051
* <p>
@@ -54,7 +55,8 @@
5455
*
5556
* @author <a href="mailto:brett@codehaus.org">Brett Porter</a>
5657
*/
57-
@Component(role = ModelloGenerator.class, hint = "dom4j-writer")
58+
@Named("dom4j-writer")
59+
@Singleton
5860
public class Dom4jWriterGenerator extends AbstractXmlJavaGenerator {
5961

6062
private boolean requiresDomSupport;

modello-plugins/modello-plugin-jackson/src/main/java/org/codehaus/modello/plugin/jackson/JacksonReaderGenerator.java

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,9 @@
2222
* SOFTWARE.
2323
*/
2424

25+
import javax.inject.Named;
26+
import javax.inject.Singleton;
27+
2528
import java.io.IOException;
2629
import java.util.List;
2730
import java.util.Properties;
@@ -32,7 +35,6 @@
3235
import org.codehaus.modello.model.ModelClass;
3336
import org.codehaus.modello.model.ModelDefault;
3437
import org.codehaus.modello.model.ModelField;
35-
import org.codehaus.modello.plugin.ModelloGenerator;
3638
import org.codehaus.modello.plugin.java.javasource.JClass;
3739
import org.codehaus.modello.plugin.java.javasource.JConstructor;
3840
import org.codehaus.modello.plugin.java.javasource.JField;
@@ -47,13 +49,13 @@
4749
import org.codehaus.modello.plugins.xml.metadata.XmlAssociationMetadata;
4850
import org.codehaus.modello.plugins.xml.metadata.XmlClassMetadata;
4951
import org.codehaus.modello.plugins.xml.metadata.XmlFieldMetadata;
50-
import org.codehaus.plexus.component.annotations.Component;
5152
import org.codehaus.plexus.util.StringUtils;
5253

5354
/**
5455
* @author <a href="mailto:simonetripodi@apache.org">Simone Tripodi</a>
5556
*/
56-
@Component(role = ModelloGenerator.class, hint = "jackson-reader")
57+
@Named("jackson-reader")
58+
@Singleton
5759
public class JacksonReaderGenerator extends AbstractJacksonGenerator {
5860

5961
private static final String SOURCE_PARAM = "source";

modello-plugins/modello-plugin-jackson/src/main/java/org/codehaus/modello/plugin/jackson/JacksonWriterGenerator.java

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,9 @@
2222
* SOFTWARE.
2323
*/
2424

25+
import javax.inject.Named;
26+
import javax.inject.Singleton;
27+
2528
import java.io.IOException;
2629
import java.util.List;
2730
import java.util.Properties;
@@ -32,7 +35,6 @@
3235
import org.codehaus.modello.model.ModelClass;
3336
import org.codehaus.modello.model.ModelDefault;
3437
import org.codehaus.modello.model.ModelField;
35-
import org.codehaus.modello.plugin.ModelloGenerator;
3638
import org.codehaus.modello.plugin.java.javasource.JClass;
3739
import org.codehaus.modello.plugin.java.javasource.JConstructor;
3840
import org.codehaus.modello.plugin.java.javasource.JField;
@@ -43,12 +45,12 @@
4345
import org.codehaus.modello.plugin.java.metadata.JavaFieldMetadata;
4446
import org.codehaus.modello.plugins.xml.metadata.XmlAssociationMetadata;
4547
import org.codehaus.modello.plugins.xml.metadata.XmlFieldMetadata;
46-
import org.codehaus.plexus.component.annotations.Component;
4748

4849
/**
4950
* @author <a href="mailto:simonetripodi@apache.org">Simone Tripodi</a>
5051
*/
51-
@Component(role = ModelloGenerator.class, hint = "jackson-writer")
52+
@Named("jackson-writer")
53+
@Singleton
5254
public class JacksonWriterGenerator extends AbstractJacksonGenerator {
5355

5456
private boolean requiresDomSupport;

modello-plugins/modello-plugin-java/src/main/java/org/codehaus/modello/plugin/java/JavaModelloGenerator.java

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,9 @@
2222
* SOFTWARE.
2323
*/
2424

25+
import javax.inject.Named;
26+
import javax.inject.Singleton;
27+
2528
import java.io.IOException;
2629
import java.io.Serializable;
2730
import java.util.Arrays;
@@ -41,7 +44,6 @@
4144
import org.codehaus.modello.model.ModelDefault;
4245
import org.codehaus.modello.model.ModelField;
4346
import org.codehaus.modello.model.ModelInterface;
44-
import org.codehaus.modello.plugin.ModelloGenerator;
4547
import org.codehaus.modello.plugin.java.javasource.JArrayType;
4648
import org.codehaus.modello.plugin.java.javasource.JClass;
4749
import org.codehaus.modello.plugin.java.javasource.JCollectionType;
@@ -60,13 +62,13 @@
6062
import org.codehaus.modello.plugin.java.metadata.JavaClassMetadata;
6163
import org.codehaus.modello.plugin.java.metadata.JavaFieldMetadata;
6264
import org.codehaus.modello.plugin.model.ModelClassMetadata;
63-
import org.codehaus.plexus.component.annotations.Component;
6465
import org.codehaus.plexus.util.StringUtils;
6566

6667
/**
6768
* @author <a href="mailto:jason@modello.org">Jason van Zyl</a>
6869
*/
69-
@Component(role = ModelloGenerator.class, hint = "java")
70+
@Named("java")
71+
@Singleton
7072
public class JavaModelloGenerator extends AbstractJavaModelloGenerator {
7173

7274
private Collection<String> immutableTypes = new HashSet<String>(Arrays.asList(new String[] {

modello-plugins/modello-plugin-java/src/main/java/org/codehaus/modello/plugin/java/metadata/JavaMetadataPlugin.java

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,9 @@
2222
* SOFTWARE.
2323
*/
2424

25+
import javax.inject.Named;
26+
import javax.inject.Singleton;
27+
2528
import java.util.Map;
2629

2730
import org.codehaus.modello.metadata.AbstractMetadataPlugin;
@@ -36,12 +39,12 @@
3639
import org.codehaus.modello.model.ModelClass;
3740
import org.codehaus.modello.model.ModelField;
3841
import org.codehaus.modello.model.ModelInterface;
39-
import org.codehaus.plexus.component.annotations.Component;
4042

4143
/**
4244
* @author <a href="mailto:evenisse@codehaus.org">Emmanuel Venisse </a>
4345
*/
44-
@Component(role = MetadataPlugin.class, hint = "java")
46+
@Named("java")
47+
@Singleton
4548
public class JavaMetadataPlugin extends AbstractMetadataPlugin implements MetadataPlugin {
4649
public static final String JAVA_ABSTRACT = "java.abstract";
4750

0 commit comments

Comments
 (0)