Upgraded RuboCop to 0.42.0.

Author: dblock

.rubocop_todo.yml

@@ -1,6 +1,6 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2016-03-15 15:48:04 -0400 using RuboCop version 0.33.0.
+# on 2016-08-20 10:53:42 -0400 using RuboCop version 0.42.0.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
@@ -12,7 +12,8 @@ Metrics/ClassLength:
   Max: 103
 
 # Offense count: 85
-# Configuration parameters: AllowURI, URISchemes.
+# Configuration parameters: AllowHeredoc, AllowURI, URISchemes.
+# URISchemes: http, https
 Metrics/LineLength:
   Max: 142
 
@@ -33,28 +34,21 @@ Style/AsciiComments:
 
 # Offense count: 2
 # Configuration parameters: EnforcedStyle, SupportedStyles.
+# SupportedStyles: nested, compact
 Style/ClassAndModuleChildren:
   Exclude:
     - 'features/steps/api_navigation.rb'
     - 'features/steps/default_config.rb'
 
-# Offense count: 14
+# Offense count: 4
 Style/Documentation:
   Exclude:
+    - 'spec/**/*'
+    - 'test/**/*'
     - 'features/steps/api_navigation.rb'
     - 'features/steps/default_config.rb'
     - 'features/support/api.rb'
     - 'features/support/fixtures.rb'
-    - 'lib/hyperclient/version.rb'
-    - 'test/faraday/connection_test.rb'
-    - 'test/hyperclient/attributes_test.rb'
-    - 'test/hyperclient/collection_test.rb'
-    - 'test/hyperclient/curie_test.rb'
-    - 'test/hyperclient/entry_point_test.rb'
-    - 'test/hyperclient/link_collection_test.rb'
-    - 'test/hyperclient/link_test.rb'
-    - 'test/hyperclient/resource_collection_test.rb'
-    - 'test/hyperclient/resource_test.rb'
 
 # Offense count: 2
 Style/DoubleNegation:
@@ -64,15 +58,23 @@ Style/DoubleNegation:
 
 # Offense count: 5
 # Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+# SupportedStyles: line_count_dependent, lambda, literal
 Style/Lambda:
   Exclude:
     - 'test/hyperclient/entry_point_test.rb'
     - 'test/hyperclient/link_test.rb'
     - 'test/hyperclient/resource_test.rb'
 
+# Offense count: 1
+Style/MethodMissing:
+  Exclude:
+    - 'lib/hyperclient/collection.rb'
+
 # Offense count: 1
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle, SupportedStyles, AllowInnerSlashes.
+# SupportedStyles: slashes, percent_r, mixed
 Style/RegexpLiteral:
   Exclude:
     - 'features/support/api.rb'

Gemfile

@@ -15,7 +15,7 @@ group :development, :test do
   gem 'yard-tomdoc'
   gem 'rake'
   gem 'simplecov', require: false
-  gem 'rubocop', '~> 0.33.0', require: false
+  gem 'rubocop', '~> 0.42.0', require: false
 end
 
 group :test do

examples/splines_api.rb

@@ -7,7 +7,7 @@
 
 # enumerate splines
 api.splines.each do |spline|
-  puts "#{spline.uuid}"
+  puts spline.uuid.to_s
   puts " reticulated: #{spline.reticulated ? 'yes' : 'no'}"
   puts " thumbnail: #{spline['images:thumbnail']}"
 end

lib/hyperclient/attributes.rb

@@ -9,7 +9,7 @@ module Hyperclient
   #   resource.attributes.title
   #
   class Attributes < Collection
-    RESERVED_PROPERTIES = [/^_links$/, /^_embedded$/] # http://tools.ietf.org/html/draft-kelly-json-hal#section-4.1
+    RESERVED_PROPERTIES = [/^_links$/, /^_embedded$/].freeze # http://tools.ietf.org/html/draft-kelly-json-hal#section-4.1
 
     # Public: Initializes the Attributes of a Resource.
     #

lib/hyperclient/collection.rb

@@ -62,7 +62,7 @@ def [](name)
     def to_h
       @collection.to_hash
     end
-    alias_method :to_hash, :to_h
+    alias to_hash to_h
 
     def to_s
       to_hash
@@ -76,7 +76,7 @@ def to_s
     # Returns an Object.
     def method_missing(method_name, *_args, &_block)
       @collection.fetch(method_name.to_s) do
-        fail "Could not find `#{method_name}` in #{self.class.name}"
+        raise "Could not find `#{method_name}` in #{self.class.name}"
       end
     end
 

lib/hyperclient/entry_point.rb

@@ -52,15 +52,15 @@ def initialize(url, &_block)
     def connection(options = {}, &block)
       @faraday_options ||= options.dup
       if block_given?
-        fail ConnectionAlreadyInitializedError if @connection
-        if @faraday_options.delete(:default) == false
-          @faraday_block = block
-        else
-          @faraday_block = lambda do |conn|
-            default_faraday_block.call conn
-            block.call conn
-          end
-        end
+        raise ConnectionAlreadyInitializedError if @connection
+        @faraday_block = if @faraday_options.delete(:default) == false
+                           block
+                         else
+                           lambda do |conn|
+                             default_faraday_block.call conn
+                             yield conn
+                           end
+                         end
       else
         @connection ||= Faraday.new(_url, faraday_options, &faraday_block)
       end
@@ -78,7 +78,7 @@ def headers
     #
     # value    - A Hash containing headers to include with every API request.
     def headers=(value)
-      fail ConnectionAlreadyInitializedError if @connection
+      raise ConnectionAlreadyInitializedError if @connection
       @headers = value
     end
 
@@ -93,7 +93,7 @@ def faraday_options
     #
     # value    - A Hash containing options to pass to Faraday
     def faraday_options=(value)
-      fail ConnectionAlreadyInitializedError if @connection
+      raise ConnectionAlreadyInitializedError if @connection
       @faraday_options = value
     end
 
@@ -108,7 +108,7 @@ def faraday_block
     #
     # value    - A Proc accepting a Faraday::Connection.
     def faraday_block=(value)
-      fail ConnectionAlreadyInitializedError if @connection
+      raise ConnectionAlreadyInitializedError if @connection
       @faraday_block = value
     end
 

lib/hyperclient/link_collection.rb

@@ -19,7 +19,7 @@ class LinkCollection < Collection
     # curies      - The Hash with link curies.
     # entry_point - The EntryPoint object to inject the configuration.
     def initialize(collection, curies, entry_point)
-      fail "Invalid response for LinkCollection. The response was: #{collection.inspect}" if collection && !collection.respond_to?(:collect)
+      raise "Invalid response for LinkCollection. The response was: #{collection.inspect}" if collection && !collection.respond_to?(:collect)
 
       @_curies = (curies || {}).reduce({}) do |hash, curie_hash|
         curie = build_curie(curie_hash, entry_point)

lib/hyperclient/resource.rb

@@ -65,7 +65,7 @@ def fetch(key, *args)
       elsif block_given?
         yield key
       else
-        fail KeyError
+        raise KeyError
       end
     end
 

lib/hyperclient/version.rb

@@ -1,3 +1,3 @@
 module Hyperclient
-  VERSION = '0.8.2'
+  VERSION = '0.8.2'.freeze
 end