Skip to content

Commit 5cd2379

Browse files
authored
chore: clean npm script (#73)
1 parent 850d4c0 commit 5cd2379

11 files changed

+142
-174
lines changed

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,8 +47,8 @@ yarn run start
4747
```bash
4848
# install dependencies
4949
yarn
50-
# rebuild native dependencies for electron
51-
yarn run electron-rebuild
50+
# rebuild native dependencies for web
51+
yarn run web-rebuild
5252
# build web
5353
yarn run build-web
5454
# start project

build/rebuild.ts

Lines changed: 11 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,12 @@ import * as path from 'node:path';
22
import { version as electronVersion } from 'electron/package.json'
33
import { nativeDeps, postInstallDeps } from './deps'
44
import { exec } from './util'
5+
import { parseArgv } from '@opensumi/ide-utils/lib/argv'
6+
7+
const argv = parseArgv(process.argv)
58

69
export const rebuild = async (config?: { arch?: string, cwd?: string, silent?: boolean, loglevel?: string }) => {
10+
const target = argv.target || 'electron'
711
const arch = config?.arch || process.arch
812
const cwd = config?.cwd || process.cwd()
913
const loglevel = config?.loglevel || 'info'
@@ -15,11 +19,13 @@ export const rebuild = async (config?: { arch?: string, cwd?: string, silent?: b
1519
'npx',
1620
'node-gyp',
1721
'rebuild',
18-
'--runtime=electron',
19-
`--target=${electronVersion}`,
20-
`--arch=${arch}`,
21-
`--dist-url=https://electronjs.org/headers`,
22-
`--loglevel=${loglevel}`
22+
...target == 'electron' ? [
23+
'--runtime=electron',
24+
`--target=${electronVersion}`,
25+
`--arch=${arch}`,
26+
`--dist-url=https://electronjs.org/headers`,
27+
`--loglevel=${loglevel}`
28+
] : []
2329
].join(' '),
2430
null,
2531
{

build/webpack-web/webpack.browser.config.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ import fs from 'fs'
88
import { createConfig, webpackDir, devServerPort } from './webpack.base.config';
99
import {config} from 'dotenv'
1010
config({
11-
path: path.join(__dirname, '../../.env')
11+
path: path.join(__dirname, '../../.env.sample')
1212
})
1313

1414
const srcDir = path.resolve('src/bootstrap-web/browser');

build/webpack-web/webpack.config.ts

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
import browser from './webpack.browser.config';
2+
import webview from './webpack.webview.config';
3+
import extHost from './webpack.ext-host.config';
4+
import workerHost from './webpack.worker-host.config'
5+
import node from './webpack.node.config';
6+
7+
export default [browser, webview, extHost, workerHost, node];

build/webpack-web/webpack.ext-host.config.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import { asarDeps } from '../deps'
55
const srcDir = path.resolve('src/bootstrap-web/ext-host');
66
const outDir = path.join(webpackDir, 'ext-host');
77

8-
module.exports = createConfig((_, argv) => ({
8+
export default createConfig((_, argv) => ({
99
entry: srcDir,
1010
output: {
1111
filename: 'index.js',

build/webpack-web/webpack.webview.config.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ const tsConfigPath = path.join(__dirname, '../../tsconfig.json');
1010
const distDir = path.join(webpackDir, 'webview');
1111
const port = 8899;
1212

13-
module.exports = {
13+
export default {
1414
entry,
1515
output: {
1616
filename: 'webview.js',

build/webpack-web/webpack.worker-host.config.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import {webpackDir} from "./webpack.base.config";
44
import {createConfig} from "../webpack/webpack.base.config";
55
const outDir = path.join(webpackDir, 'ext-host');
66

7-
module.exports = createConfig({
7+
export default createConfig({
88
entry: require.resolve('@opensumi/ide-extension/lib/hosted/worker.host-preload'),
99
output: {
1010
filename: 'worker-host.js',

package.json

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,14 +5,15 @@
55
"main": "out/main",
66
"scripts": {
77
"start": "electron-forge start",
8+
"start-web": "ts-node build/webpack-web/web-start.ts",
9+
"electron-rebuild": "node -r ts-node/register ./build/rebuild.ts",
10+
"web-rebuild": "node -r ts-node/register ./build/rebuild.ts --target=web",
11+
"build-web": "webpack --config ./build/webpack-web/webpack.config.ts --progress --color",
812
"package": "electron-forge package",
913
"make": "electron-forge make",
10-
"electron-rebuild": "node -r ts-node/register ./build/rebuild.ts",
1114
"changelog": "conventional-changelog -p angular -i CHANGELOG.md -s",
1215
"release": "standard-version",
13-
"release:minor": "npm run release -- --release-as minor",
14-
"build-web": "webpack --config ./build/webpack-web/webpack.browser.config.ts --progress --color && webpack --config ./build/webpack-web/webpack.webview.config.ts --progress --color && webpack --config ./build/webpack-web/webpack.ext-host.config.ts --progress --color && webpack --config ./build/webpack-web/webpack.worker-host.config.ts --progress --color && webpack --config ./build/webpack-web/webpack.node.config.ts --progress --color",
15-
"start-web": "ts-node build/webpack-web/web-start.ts"
16+
"release:minor": "npm run release -- --release-as minor"
1617
},
1718
"repository": {
1819
"type": "git",

src/bootstrap-web/common/index.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,5 +2,5 @@ import {config} from 'dotenv'
22
import path from "path";
33

44
config({
5-
path: path.resolve(__dirname, '../../../.env')
5+
path: path.resolve(__dirname, '../../../..env.sample')
66
})

src/logger/node/log-manager.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,6 @@ export class LogServiceManager extends AbstractLogServiceManager {
1010
}
1111

1212
getLogFolder(): string {
13-
return path.join(process.env.IDE_LOG_HOME!, `window${process.env.CODE_WINDOW_CLIENT_ID!.slice('CODE_WINDOW_CLIENT_ID:'.length)}`)
13+
return path.join(process.env.IDE_LOG_HOME || '', `window${process.env.CODE_WINDOW_CLIENT_ID?.slice('CODE_WINDOW_CLIENT_ID:'?.length)}`)
1414
}
1515
}

0 commit comments

Comments
 (0)