chore: removed unused env var in app-proxy #565
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ATGardner
commented
Jul 7, 2025
| @@ -12,7 +12,6 @@ GIT_USERNAME: {{ .Values.global.runtime.gitCredentials.username }} | |||
| GIT_PASSWORD: | |||
| {{- include "codefresh-gitops-runtime.runtime-gitcreds.password.env-var-value" . | nindent 2 }} | |||
| {{- end }} | |||
| WORKFLOW_PIPELINES_WEBHOOKS_TLS_SECRET: codefresh-workflow-pipelines-tls | |||
There was a problem hiding this comment.
was not used anywhere in the code
zarbis
approved these changes
Jul 7, 2025
|
/e2e |
2 similar comments
|
/e2e |
|
/e2e |
|
/e2e |
1 similar comment
|
/e2e |
ilia-medvedev-codefresh
approved these changes
Jul 8, 2025
|
/e2e |
2 similar comments
|
/e2e |
|
/e2e |
ATGardner
force-pushed
the
bump-app-proxy
branch
2 times, most recently
from
424fec7 to
dc600eb
Compare
|
/e2e |
This change introduces the GIT_SSL_CAINFO variable to specify the location of the CA certificate for SSL connections, enhancing the security of Git operations within the app-proxy environment. Additionally, it removes the WORKFLOW_PIPELINES_WEBHOOKS_TLS_SECRET variable to streamline the configuration.
This change removes the GIT_SSL_CAINFO variable from the environment variables defined for the cap-app-proxy container. This adjustment ensures that the configuration aligns with the current security standards and practices.
ATGardner
force-pushed
the
bump-app-proxy
branch
from
dc600eb to
b5350f1
Compare
ATGardner
changed the title
|
/e2e |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
app-proxy will send current env vars to simple-git execution
added GIT_SSAL_CAINFO to let git binary access self-signed servers
Why
on-prem git servers with self-signed certificates would fail cloning.
Notes