chore: remove deprecated event reporter templates for rollout and wor… #490
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ATGardner
approved these changes
May 19, 2025
|
/e2e |
dmaizel
force-pushed
the
feat/remove-eventsources-and-sensors
branch
from
2a09829 to
5683c1d
Compare
ilia-medvedev-codefresh
approved these changes
May 21, 2025
dmaizel
force-pushed
the
feat/remove-eventsources-and-sensors
branch
from
9723638 to
2f59594
Compare
|
/e2e |
2 similar comments
|
/e2e |
|
/e2e |
dmaizel
force-pushed
the
feat/remove-eventsources-and-sensors
branch
from
2f59594 to
434662f
Compare
|
/e2e |
1 similar comment
|
/e2e |
dmaizel
force-pushed
the
feat/remove-eventsources-and-sensors
branch
from
434662f to
4f990cf
Compare
|
/e2e |
1 similar comment
|
/e2e |
dmaizel
force-pushed
the
feat/remove-eventsources-and-sensors
branch
from
4f990cf to
63073a0
Compare
|
/e2e |
2 similar comments
|
/e2e |
|
/e2e |
dmaizel
force-pushed
the
feat/remove-eventsources-and-sensors
branch
from
7e7fabb to
583c27c
Compare
…ard compatibility - Add event-reporters.workflow.serviceAccount configuration to values.yaml - Add helper functions for workflow reporter service account in _helpers.tpl - Create workflow-reporter-sa.yaml template to provision codefresh-sa service account - Maintains backward compatibility with e2e tests and existing workflows - Service account created only when event-reporters.workflow.serviceAccount.create is true - Defaults to 'codefresh-sa' name when no custom name is specified Resolves e2e test failures due to missing codefresh-sa service account after event-reporters removal.
…account - Create workflow-reporter-rbac.yaml with Role and RoleBinding - Grants full namespace permissions (all apiGroups, resources, verbs) - Restores same permissions as original workflow-reporter service account - Ensures backward compatibility for e2e tests requiring elevated permissions
dmaizel
force-pushed
the
feat/remove-eventsources-and-sensors
branch
from
d874904 to
e758cec
Compare
|
/e2e |
1 similar comment
|
/e2e |
dmaizel
added a commit
that referenced
this pull request
Jun 10, 2025
dmaizel
added a commit
that referenced
this pull request
Jun 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…kflow components
What
Why
Notes