Skip to content

Commit 92357a5

Browse files
Fix - Workflows native UI via internal router (#153)
* native ui routing - rewrite target * native ui routing - rewrite target * native ui routing - rewrite target
1 parent e75fcc8 commit 92357a5

File tree

4 files changed

+7
-0
lines changed

4 files changed

+7
-0
lines changed

charts/gitops-runtime/Chart.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,8 @@ annotations:
2020
description: Update argo-cd chart to 5.51.6-8-cap-2.9-2024.1.24-ccd7124b3. Includes: window rate limiter for the event reporter; support of apps in non-contoller namespaces for non-GRPC reporting mode; critical vuln fixes for argocd;
2121
- kind: changed
2222
description: Update argo-rollouts chart to 2.32.5-3-analysis-fix
23+
- kind: fixed
24+
description: fix routing to workflows native UI
2325
dependencies:
2426
- name: argo-cd
2527
repository: https://codefresh-io.github.io/argo-helm

charts/gitops-runtime/README.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -160,6 +160,7 @@ sealed-secrets:
160160
| argo-workflows.crds.install | bool | `true` | Install and upgrade CRDs |
161161
| argo-workflows.enabled | bool | `true` | |
162162
| argo-workflows.fullnameOverride | string | `"argo"` | |
163+
| argo-workflows.server.baseHref | string | `"/workflows/"` | Do not change. Workflows UI is only accessed through internal router, changing this values will break routing to workflows native UI from Codefresh. |
163164
| argo-workflows.server.extraArgs | list | `["--auth-mode=client"]` | auth-mode needs to be set to client to be able to see workflow logs from Codefresh UI |
164165
| event-reporters.events.argoCDServerServiceName | string | `nil` | LEAVE EMPTY and let the chart logic determine the name. Change only if you are totally sure you need to override ArgoCD service name. |
165166
| event-reporters.events.argoCDServerServicePort | string | `nil` | LEAVE EMPTY and let the chart logic determine the name. Change only if you are totally sure you need to override ArgoCD service port. |

charts/gitops-runtime/templates/_components/internal-router/_configmap.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ data:
1010
listen [::]:8080 default_server;
1111
access_log /dev/stdout main;
1212
error_log /dev/stdout;
13+
port_in_redirect off;
1314
1415
{{- if .Values.resolver }}
1516
resolver {{ .Values.resolver }} valid=10s;
@@ -33,6 +34,7 @@ data:
3334
proxy_set_header Connection '';
3435
proxy_http_version 1.1;
3536
chunked_transfer_encoding off;
37+
rewrite /workflows(/|$)(.*) /$2 break;
3638
3739
proxy_pass {{ .Values.routing.workflows.internalUrl }};
3840
}

charts/gitops-runtime/values.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -176,6 +176,8 @@ argo-workflows:
176176
# -- auth-mode needs to be set to client to be able to see workflow logs from Codefresh UI
177177
extraArgs:
178178
- --auth-mode=client
179+
# -- Do not change. Workflows UI is only accessed through internal router, changing this values will break routing to workflows native UI from Codefresh.
180+
baseHref: /workflows/
179181
crds:
180182
# -- Install and upgrade CRDs
181183
install: true

0 commit comments

Comments
 (0)