refactor: use templateScope var instead of repeatedly retrieving it from function (argoproj#13345)

qingfeng777 · web-flow · commit 61f3fd416af4 · 2024-07-16T12:10:08.000+01:00
Signed-off-by: qingfeng777 &lt;251098199@qq.com&gt;
diff --git a/workflow/controller/operator.go b/workflow/controller/operator.go
@@ -1891,7 +1891,7 @@ func (woc *wfOperationCtx) executeTemplate(ctx context.Context, nodeName string,
 	defer func() { woc.currentStackDepth-- }()
 
 	if woc.currentStackDepth >= woc.controller.maxStackDepth && os.Getenv("DISABLE_MAX_RECURSION") != "true" {
-		return woc.initializeNodeOrMarkError(node, nodeName, tmplCtx.GetTemplateScope(), orgTmpl, opts.boundaryID, opts.nodeFlag, ErrMaxDepthExceeded), ErrMaxDepthExceeded
+		return woc.initializeNodeOrMarkError(node, nodeName, templateScope, orgTmpl, opts.boundaryID, opts.nodeFlag, ErrMaxDepthExceeded), ErrMaxDepthExceeded
 	}
 
 	newTmplCtx, resolvedTmpl, templateStored, err := tmplCtx.ResolveTemplate(orgTmpl)

Original file line number	Diff line number	Diff line change
`@@ -1891,7 +1891,7 @@ func (woc *wfOperationCtx) executeTemplate(ctx context.Context, nodeName string,`
`1891`	`1891`	`defer func() { woc.currentStackDepth-- }()`
`1892`	`1892`
`1893`	`1893`	`if woc.currentStackDepth >= woc.controller.maxStackDepth && os.Getenv("DISABLE_MAX_RECURSION") != "true" {`
`1894`		`- return woc.initializeNodeOrMarkError(node, nodeName, tmplCtx.GetTemplateScope(), orgTmpl, opts.boundaryID, opts.nodeFlag, ErrMaxDepthExceeded), ErrMaxDepthExceeded`
	`1894`	`+ return woc.initializeNodeOrMarkError(node, nodeName, templateScope, orgTmpl, opts.boundaryID, opts.nodeFlag, ErrMaxDepthExceeded), ErrMaxDepthExceeded`
`1895`	`1895`	`}`
`1896`	`1896`
`1897`	`1897`	`newTmplCtx, resolvedTmpl, templateStored, err := tmplCtx.ResolveTemplate(orgTmpl)`