Implement strategy to use unique validations

Author: NickSchimek

models/base_model.py

@@ -32,6 +32,10 @@ def create(cls, schema, payload):
         return obj
 
     def update(self, schema, payload, context=None):
+        if not context:
+            context = {}
+
+        context["obj"] = self
         attrs = self.validate(schema, payload, context=context, partial=True)
 
         for k, v in attrs.items():

schemas/user.py

@@ -1,7 +1,9 @@
 from ma import ma
-from models.user import UserModel, RoleEnum
+from sqlalchemy import inspect
 from marshmallow import fields, validates, ValidationError
 
+from models.user import UserModel, RoleEnum
+
 
 class UserSchema(ma.SQLAlchemyAutoSchema):
     class Meta:
@@ -12,7 +14,14 @@ class Meta:
 
     @validates("email")
     def validate_uniqueness_of_email(self, value):
-        if UserModel.find_by_email(value):
+        obj = self.context.get("obj")
+        if obj:
+            obj.email = value
+            if inspect(
+                obj
+            ).attrs.email.history.has_changes() and UserModel.find_by_email(value):
+                raise ValidationError(f"A user with email '{value}' already exists")
+        elif UserModel.find_by_email(value):
             raise ValidationError(f"A user with email '{value}' already exists")
 
     def get_role_value(self, obj):

tests/integration/test_users.py

@@ -1,5 +1,6 @@
 import pytest
 from unittest.mock import patch
+from db import db
 from models.user import UserModel
 from models.users.admin import Admin
 from schemas import UserRegisterSchema
@@ -132,7 +133,10 @@ def test_role_update(self, valid_header, create_unauthorized_user):
         payload = {"role": RoleEnum.ADMIN.value}
         self.client.patch(f"api/user/{id}", json=payload, headers=valid_header)
 
-        assert Admin.find(id).role == RoleEnum.ADMIN
+        db.session.rollback()
+        user = UserModel.find(id)
+        assert user.role == RoleEnum.ADMIN
+        assert user.type == "admin"
 
 
 @pytest.mark.usefixtures("client_class", "empty_test_db")

tests/unit/base_interface_test.py

@@ -59,7 +59,8 @@ def test_update(self, mock_session):
         with patch.object(self.object, "validate", return_value={}) as mock_validate:
             response = self.object.update(schema=self.schema, payload={})
 
-        mock_validate.assert_called_with(self.schema, {}, context=None, partial=True)
+        context = {"obj": self.object}
+        mock_validate.assert_called_with(self.schema, {}, context=context, partial=True)
         mock_session.add.assert_called_with(self.object)
         mock_session.commit.assert_called()