Skip to content
This repository was archived by the owner on Dec 19, 2021. It is now read-only.

Commit 73d08ab

Browse files
committed
Cascade note deletion when the ticket is deleted
Fixes codeforpdx/dwellingly-app/issues/762
1 parent d368491 commit 73d08ab

File tree

2 files changed

+11
-6
lines changed

2 files changed

+11
-6
lines changed

models/notes.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,9 @@ class NotesModel(BaseModel):
99
id = db.Column(db.Integer, primary_key=True)
1010
text = db.Column(db.Text)
1111
user_id = db.Column(db.Integer, db.ForeignKey("users.id"), nullable=False)
12-
ticket_id = db.Column(db.Integer, db.ForeignKey("tickets.id"), nullable=False)
12+
ticket_id = db.Column(
13+
db.Integer, db.ForeignKey("tickets.id", ondelete="CASCADE"), nullable=False
14+
)
1315

1416
def json(self):
1517

tests/integration/test_tickets.py

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -88,13 +88,16 @@ def test_create_ticket(self, valid_header, ticket_attributes):
8888

8989

9090
class TestTicketsDELETE(BaseConfig):
91-
def test_delete_many(self, valid_header, create_ticket):
92-
ticket_1 = create_ticket()
93-
ticket_2 = create_ticket()
94-
delete_ids = {"ids": [ticket_1.id, ticket_2.id]}
91+
def test_delete_many(self, valid_header, create_note):
92+
note_1 = create_note()
93+
note_2 = create_note()
94+
ticket_1 = note_1.ticket
95+
ticket_2 = note_2.ticket
9596

9697
response = self.client.delete(
97-
self.endpoint, json=delete_ids, headers=valid_header
98+
self.endpoint,
99+
json={"ids": [ticket_1.id, ticket_2.id]},
100+
headers=valid_header
98101
)
99102
db.session.rollback()
100103

0 commit comments

Comments
 (0)