Skip to content

Result view - include label/name in tooltip #383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 28, 2025

Conversation

janfh
Copy link
Contributor

@janfh janfh commented Apr 22, 2025

Fixes #380

Adds a second line in the tooltip when hovering the result view header that includes label or name depending on what is used in the header.

warning: manager.ts is modified to enable extended metadata by default (this is the same behaviour as ACS).

@worksofliam worksofliam modified the milestones: Fix day 2, Fix day 1.5 Apr 22, 2025
@worksofliam
Copy link
Contributor

Screenshot 2025-04-28 at 3 41 34 PM

@janfh I tried this today but I can't seem to get the label to show. What am I missing?

LABEL ON COLUMN SNDBX87.DEPARTMENT (deptno is 'department number');

SELECT * FROM SNDBX87.DEPARTMENT as a;

@janfh
Copy link
Contributor Author

janfh commented Apr 28, 2025

@worksofliam : Can you please verify that extended metadata is enabled for the connection?

@worksofliam
Copy link
Contributor

@janfh I can confirm it is.

@worksofliam
Copy link
Contributor

worksofliam commented Apr 28, 2025

@janfh I just noticed there is no change to manager.ts in this PR!

I see it come through when I set it manually:

image

@janfh
Copy link
Contributor Author

janfh commented Apr 28, 2025

@worksofliam : Looks like I managed to revert extended metadata when merging from master. Appears to be working now, but I can test it some more

@worksofliam
Copy link
Contributor

@janfh i will test again. Thank you!

Copy link
Contributor

@worksofliam worksofliam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! I also tested the label showing in the title and that is working as expected also.

Screenshot 2025-04-28 at 4 40 46 PM

@worksofliam worksofliam merged commit 3d61ddf into codefori:main Apr 28, 2025
1 check passed
@janfh janfh deleted the feature/column_label_preview branch April 29, 2025 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancement: add column text to column hover preview
2 participants