Skip to content

Right click option on SQL objects to view record locks #314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Apr 16, 2025

Conversation

janfh
Copy link
Contributor

@janfh janfh commented Jan 5, 2025

A new context option to view record locks similar to the one found in Schemas in ACS

image

image

@worksofliam worksofliam self-requested a review January 7, 2025 13:58
@worksofliam
Copy link
Contributor

@janfh I won't review this until the conflicts have been resolved. Guessing due to the fact I merged your other PR.

@janfh
Copy link
Contributor Author

janfh commented Jan 7, 2025

@janfh I won't review this until the conflicts have been resolved. Guessing due to the fact I merged your other PR.

I'll wait to see if #313 is merged or declined first

janfh added 9 commits January 9, 2025 13:55
# Conflicts:
#	package.json
#	src/views/schemaBrowser/contributes.json
#	src/views/schemaBrowser/index.ts
#	src/views/schemaBrowser/statements.ts
…record_locks

# Conflicts:
#	src/views/schemaBrowser/index.ts
… feature/record_locks

# Conflicts:
#	package.json
#	src/views/schemaBrowser/contributes.json
#	src/views/schemaBrowser/index.ts
#	src/views/schemaBrowser/statements.ts
# Conflicts:
#	src/views/schemaBrowser/index.ts
# Conflicts:
#	src/views/schemaBrowser/index.ts
@janfh
Copy link
Contributor Author

janfh commented Apr 10, 2025

@worksofliam : Is this something you would consider to merge? If not feel free to close it :)

@worksofliam
Copy link
Contributor

@janfh absolutely let's get it in!

I am going to put it on my fix day list and merge with that.

@worksofliam worksofliam added this to the Fix day milestone Apr 10, 2025
@worksofliam
Copy link
Contributor

Asked @forstie for a review of the SQL statement.

@worksofliam worksofliam requested a review from forstie April 16, 2025 15:17
@worksofliam worksofliam added the enhancement New feature or request label Apr 16, 2025
@janfh janfh requested a review from forstie April 16, 2025 15:46
@forstie
Copy link
Collaborator

forstie commented Apr 16, 2025

Hi
I tested the enhancement and only noticed one thing... the member name.
Please change it to this: (in this way, if the member name is a delimited name, the name returned by the action will be a complete name)

qsys2.delimit_name(table_partition) "Member"

@janfh
Copy link
Contributor Author

janfh commented Apr 16, 2025

@forstie : I have added delimit_name. Just out of curiosity - do you have an example of a member name that could cause a issue here?

@forstie
Copy link
Collaborator

forstie commented Apr 16, 2025

Hi,
Here's the example I used for testing:

create schema "crazytown";

CREATE OR REPLACE TABLE "crazytown"."crazytable" FOR SYSTEM NAME "craz0001" (
"crazycolumn" FOR COLUMN CC1 INTEGER DEFAULT NULL )

RCDFMT "craz0001" ;

insert into "crazytown"."crazytable" values(1);
update "crazytown"."crazytable" set "crazycolumn" = 2 limit 2;
commit;
select qsys2.delimit_name(table_partition) "Member" from qsys2.record_lock_info where table_schema = 'crazytown';

@worksofliam worksofliam merged commit 9fe4f05 into codefori:main Apr 16, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants