Skip to content

Commit 2c15994

Browse files
committed
Sort on schema filter
Signed-off-by: worksofliam <mrliamallan@live.co.uk>
1 parent ff49a75 commit 2c15994

File tree

2 files changed

+6
-12
lines changed

2 files changed

+6
-12
lines changed

src/database/schemas.ts

Lines changed: 5 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -356,18 +356,12 @@ export default class Schemas {
356356

357357
let query: string;
358358

359-
if (selects.length > 1) {
360-
if (details.sort) {
361-
query = `with results as (${selects.join(
362-
" UNION ALL "
363-
)}) select * from results Order by QSYS2.DELIMIT_NAME(NAME) asc`;
364-
} else {
365-
query = selects.join(` UNION ALL `);
366-
}
367-
359+
if (details.sort) {
360+
query = `with results as (${selects.join(
361+
" UNION ALL "
362+
)}) select * from results Order by QSYS2.DELIMIT_NAME(NAME) asc`;
368363
} else {
369-
// TODO: sort single
370-
query = selects[0];
364+
query = selects.join(` UNION ALL `);
371365
}
372366

373367
const objects: any[] = await JobManager.runSQL(

src/views/schemaBrowser/index.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -492,7 +492,7 @@ export default class schemaBrowser {
492492
let filterValue = this.filters[element.schema];
493493
if (filterValue) {
494494
const validSchemaName = Statement.noQuotes(element.schema);
495-
const filteredObjects = await Schemas.getObjects(validSchemaName, AllSQLTypes, { filter: filterValue });
495+
const filteredObjects = await Schemas.getObjects(validSchemaName, AllSQLTypes, { filter: filterValue, sort: true });
496496
items = filteredObjects.map(obj => new SQLObject(obj));
497497

498498
} else {

0 commit comments

Comments
 (0)