Skip to content

clarify some "Getting Started" text in the Local Deployment section #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jwoehr
Copy link

@jwoehr jwoehr commented May 29, 2025

Like it sez .. found the text as-is a little confusing

Copy link
Contributor

@sebjulliand sebjulliand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jwoehr !
There is just one misunderstanding that must be fixed. The rest is OK 👌🏻

* if no `actions.json` file is found will ask the user if they'd like to create a default
3. a new right-click option will appear on IFS directories to deploy to that directory
4. a 'Deploy' button will appear on the status bar
* ask the user if they'd like to create a default `actions.json` file if no `actions.json` file is found in the user's `~/.vscode` directory on the IBM i.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we're talking about local development here, Code for i will look for actions.json in the .vscode folder that should be located at the root of the workspace, not in the user's home directory on the IFS.

@jwoehr
Copy link
Author

jwoehr commented May 30, 2025

Well, I'm certainly not clear in this. I've set this up but I can't find that actions.json file where you say. Is it at the root of the workspace on the workstation, or at the root of the builds directory on the IBM i?

@worksofliam
Copy link
Contributor

@jwoehr the actions.json file exists at .vscode/actions.json in the workspace folder.

@jwoehr
Copy link
Author

jwoehr commented May 30, 2025

I don't see any such folder in the workspace folder I created (nor anywhere on my hard disk which I searched afterwards)

jwoehr@pop-os:~/work/Seiden/Workspaces$ ls -alR
.:
total 20
drwxrwxr-x  4 jwoehr jwoehr 4096 May 29 09:39 .
drwxrwxr-x 41 jwoehr jwoehr 4096 May 29 09:33 ..
drwxrwxr-x  2 jwoehr jwoehr 4096 May 29 09:35 cobol
drwxrwxr-x  2 jwoehr jwoehr 4096 May 29 09:36 rpg
-rw-rw-r--  1 jwoehr jwoehr   90 May 29 09:48 seiden.code-workspace

./cobol:
total 36
drwxrwxr-x 2 jwoehr jwoehr 4096 May 29 09:35 .
drwxrwxr-x 4 jwoehr jwoehr 4096 May 29 09:39 ..
-rw-r--r-- 1 jwoehr jwoehr 9611 May 24 23:00 corpdata.cblsqli
-rw-r--r-- 1 jwoehr jwoehr  894 Apr 30 21:51 decimal_numbers.cblle
-rw-r--r-- 1 jwoehr jwoehr  479 Feb 13  2023 mult0.cblle
-rw-r--r-- 1 jwoehr jwoehr  415 Feb 13  2023 mult0sub.cblle
-rw-r--r-- 1 jwoehr jwoehr  258 May 24 12:35 mycob.cblle

./rpg:
total 24
drwxrwxr-x 2 jwoehr jwoehr 4096 May 29 09:36 .
drwxrwxr-x 4 jwoehr jwoehr 4096 May 29 09:39 ..
-rw-r--r-- 1 jwoehr jwoehr  685 Jul 22  2023 gartner1.rpgle
-rw-r--r-- 1 jwoehr jwoehr 3130 Sep 30  2023 iconv_h.rpgle
-rw-r--r-- 1 jwoehr jwoehr  261 May 31  2023 proctest.rpgle
-rw-r--r-- 1 jwoehr jwoehr 1305 Sep 30  2023 rpgprintf.rpgle

@jwoehr
Copy link
Author

jwoehr commented May 30, 2025

I do find a .vscode/actions.json in my home dir on the IBM i dated some weeks ago.

@jwoehr
Copy link
Author

jwoehr commented May 30, 2025

So what is the definition of "workspace folder" ... the one on my pc? or the parent directory of build on the IBM i?

@worksofliam
Copy link
Contributor

@jwoehr Here is the docs on a workspace: basically one or more folders opened inside of VS Code.

https://code.visualstudio.com/docs/editing/workspaces/workspaces

@jwoehr
Copy link
Author

jwoehr commented May 30, 2025

Right @worksofliam that's what I thought.
Only ... there is no .vscode folder in my workspace.
Here is my workspace:
image
And here is the recursive listing of that workspace:

jwoehr@pop-os:~/work/Seiden/Workspaces$ ls -lR
.:
total 12
drwxrwxr-x 2 jwoehr jwoehr 4096 May 29 09:35 cobol
drwxrwxr-x 2 jwoehr jwoehr 4096 May 29 09:36 rpg
-rw-rw-r-- 1 jwoehr jwoehr   90 May 29 09:48 seiden.code-workspace

./cobol:
total 28
-rw-r--r-- 1 jwoehr jwoehr 9611 May 24 23:00 corpdata.cblsqli
-rw-r--r-- 1 jwoehr jwoehr  894 Apr 30 21:51 decimal_numbers.cblle
-rw-r--r-- 1 jwoehr jwoehr  479 Feb 13  2023 mult0.cblle
-rw-r--r-- 1 jwoehr jwoehr  415 Feb 13  2023 mult0sub.cblle
-rw-r--r-- 1 jwoehr jwoehr  258 May 24 12:35 mycob.cblle

./rpg:
total 16
-rw-r--r-- 1 jwoehr jwoehr  685 Jul 22  2023 gartner1.rpgle
-rw-r--r-- 1 jwoehr jwoehr 3130 Sep 30  2023 iconv_h.rpgle
-rw-r--r-- 1 jwoehr jwoehr  261 May 31  2023 proctest.rpgle
-rw-r--r-- 1 jwoehr jwoehr 1305 Sep 30  2023 rpgprintf.rpgle

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants