URLProtocol Removal (#128)

Author: codefiesta

Sources/OAuthKit/OAuth+Provider.swift

@@ -40,9 +40,6 @@ extension OAuth {
         public var customUserAgent: String?
         /// Enables provider debugging. Off by default.
         public var debug: Bool
-        /// An optional regex that can be used in conjuction with the ``OAuth/URLProtocol`` class to intercept outbound requests
-        /// and inject an `Authorization: Bearer <<token>>` header into a request. 
-        public var authorizationPattern: String?
 
         /// The coding keys.
         enum CodingKeys: String, CodingKey {
@@ -58,7 +55,6 @@ extension OAuth {
             case encodeHttpBody
             case customUserAgent
             case debug
-            case authorizationPattern
         }
 
         /// Public initializer.
@@ -75,7 +71,6 @@ extension OAuth {
         ///   - encodeHttpBody: If the provider should encode the access token parameters into the http body (true by default)
         ///   - customUserAgent: The custom user agent to send with browser requests.
         ///   - debug: Boolean to pass debugging into to the standard output (false by default)
-        ///   - authorizationPattern: a regex pattern used to automatically match outbound url requests that should have authorization headers added
         public init(id: String,
                     icon: URL? = nil,
                     authorizationURL: URL,
@@ -87,8 +82,7 @@ extension OAuth {
                     scope: [String]? = nil,
                     encodeHttpBody: Bool = true,
                     customUserAgent: String? = nil,
-                    debug: Bool = false,
-                    authorizationPattern: String? = nil) {
+                    debug: Bool = false) {
             self.id = id
             self.icon = icon
             self.authorizationURL = authorizationURL
@@ -101,7 +95,6 @@ extension OAuth {
             self.encodeHttpBody = encodeHttpBody
             self.customUserAgent = customUserAgent
             self.debug = debug
-            self.authorizationPattern = authorizationPattern
         }
 
         /// Custom decoder initializer.
@@ -121,7 +114,6 @@ extension OAuth {
             encodeHttpBody = try container.decodeIfPresent(Bool.self, forKey: .encodeHttpBody) ?? true
             customUserAgent = try container.decodeIfPresent(String.self, forKey: .customUserAgent)
             debug = try container.decodeIfPresent(Bool.self, forKey: .debug) ?? false
-            authorizationPattern = try container.decodeIfPresent(String.self, forKey: .authorizationPattern)
         }
     }
 }

Sources/OAuthKit/OAuth+URLProtocol.swift

@@ -157,7 +157,6 @@ public extension OAuth {
     func clear() {
         debugPrint("⚠️ [Clearing oauth state]")
         keychain.clear()
-        URLProtocol.clear()
         state = .empty
     }
 }
@@ -278,7 +277,6 @@ private extension OAuth {
     func publish(state: State) {
         switch state {
         case .authorized(let provider, let auth):
-            addAuthorization(provider: provider, authorization: auth)
             schedule(provider: provider, auth: auth)
         case .receivedDeviceCode(let provider, let deviceCode):
             schedule(provider: provider, deviceCode: deviceCode)
@@ -288,14 +286,6 @@ private extension OAuth {
         self.state = state
     }
 
-    /// Adds a received authorization to the ``OAuth/URLProtocol`` class.
-    /// - Parameters:
-    ///   - provider: the provider
-    ///   - authorization: the authorization issued by the provider
-    func addAuthorization(provider: Provider, authorization: Authorization) {
-        URLProtocol.addAuthorization(authorization, for: provider)
-    }
-
     /// Schedules the provider to be polled for authorization with the specified device token.
     /// - Parameters:
     ///   - provider: the oauth provider

Sources/OAuthKit/OAuth.swift

@@ -48,6 +48,3 @@ let oauth: OAuth = .init(.module, options: options)
 
 - ``state``
 - ``providers``
-
-### OAuth Authorization Headers
-- ``OAuthKit/OAuth/URLProtocol``

Sources/OAuthKit/OAuthKit.docc/Extensions/OAuth.md

@@ -7,7 +7,7 @@
 
 @Tutorials(name: "Tutorials") {
     @Intro(title: "OAuthKit Tutorials") {
-        Learn how to start OAuth flows, observe state changes, and use authorization tokens in API requests using URLProtocols.
+        Learn how to start OAuth flows and observe state changes.
 
         @Image(source: tutorial-card.jpg, alt: "tutorial")
     }
@@ -19,12 +19,4 @@
         Learn the basics of how to create observable ``OAuth`` instances and start authorization flows.
         @TutorialReference(tutorial: "doc:FlowsStates")
     }
-
-    @Chapter(name: "URLProtocols with OAuthKit") {
-        
-        @Image(source: blueprint-card.jpg, alt: "OAuthKit")
-        
-        Leverage the ``OAuth/URLProtocol`` class to automatically have `Authorization` header values injected into matching outbound `URLRequest`.
-        @TutorialReference(tutorial: "doc:URLProtocol")
-    }
 }