Stop parsing continuation lines in number literals #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inaki-amatria
requested review from
alvrogd and
igarcia0
and removed request for
a team
alvrogd
approved these changes
Apr 2, 2025
src/scanner.c
Outdated
Comment on lines
76
to
82
| // Return an error if a line continuation is found. This scanner cannot | ||
| // handle line continuations, particularly in cases like: | ||
| // | ||
| // ```fortran | ||
| // b = 6& ! foo | ||
| // 7; | ||
| // ``` |
There was a problem hiding this comment.
This code wouldn't even compile, right? To clarify that it's not a limitation of the scanner.
There was a problem hiding this comment.
Nice catch! I have now updated the example. TYSM
The previous algorithm incorrectly handled line continuations in number literals. Instead of attempting to parse them incorrectly, we now treat them as a parsing error. This allows library users to handle such cases explicitly.
inaki-amatria
force-pushed
the
feature/ErrorOnContinuationLinesInNumberLiterals
branch
from
6231225 to
d563cbf
Compare
inaki-amatria
deleted the
feature/ErrorOnContinuationLinesInNumberLiterals
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous algorithm incorrectly handled line continuations in number literals. Instead of attempting to parse them incorrectly, we now treat them as a parsing error. This allows library users to handle such cases explicitly.