Skip to content

Log unknown FCM errors #302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rschef wants to merge 1 commit into
base: main
Choose a base branch
from
+12 −2
Open

Log unknown FCM errors #302

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions lib/pigeon/fcm/error.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@ defmodule Pigeon.FCM.Error do

alias Pigeon.FCM.Notification

require Logger

@doc false
@spec parse(map) :: Notification.error_response()
def parse(%{"details" => details} = error), do: parse_details(details, error)
Expand All @@ -15,7 +17,11 @@ defmodule Pigeon.FCM.Error do
defp parse_details([], error), do: parse_status(error)

defp parse_status(%{"status" => status}), do: parse_response(status)
defp parse_status(_), do: :unknown_error

defp parse_status(unknown_status) do
Logger.error("Unknown FCM status: #{inspect(unknown_status)}")
:unknown_error
end

defp parse_response("INTERNAL"), do: :internal
defp parse_response("INVALID_ARGUMENT"), do: :invalid_argument
Expand All @@ -26,5 +32,9 @@ defmodule Pigeon.FCM.Error do
defp parse_response("UNAVAILABLE"), do: :unavailable
defp parse_response("UNREGISTERED"), do: :unregistered
defp parse_response("UNSPECIFIED_ERROR"), do: :unspecified_error
defp parse_response(_other), do: :unknown_error

defp parse_response(unknown_error) do
Logger.error("Unknown FCM error: #{inspect(unknown_error)}")
:unknown_error
end
end