Skip to content
This repository was archived by the owner on Jan 10, 2023. It is now read-only.

Commit 2edb1b1

Browse files
authored
Merge pull request #200 from codecov/remove-flaky-test
Remove flaky test and update README
2 parents 9d73613 + 4daaf53 commit 2edb1b1

File tree

3 files changed

+6
-32
lines changed

3 files changed

+6
-32
lines changed

README.md

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
# Codecov NodeJS Uploader
22

3+
[![codecov.io](https://codecov.io/github/codecov/codecov-node/coverage.svg?branch=master)](https://codecov.io/github/codecov/codecov-node?branch=master)
34
[![NPM version][npm-image]][npm-url]
5+
[![Build Status][github-actions-image]][github-actions-url]
46
[![Build Status][travis-image]][travis-url]
5-
[![Build Status][appveyor-image]][appveyor-url]
6-
[![codecov.io](https://codecov.io/github/codecov/codecov-node/coverage.svg?branch=master)](https://codecov.io/github/codecov/codecov-node?branch=master)
77
[![Dependency Status][depstat-image]][depstat-url]
88
[![Dev Dependency Status][devdepstat-image]][devdepstat-url]
99

@@ -68,10 +68,11 @@ istanbul cover test.js
6868
./node_modules/.bin/codecov
6969
```
7070

71+
[appveyor-url]: https://ci.appveyor.com/project/eddiemoore/codecov-node-s38o6/branch/master
72+
[github-actions-image]: https://github.com/codecov/codecov-node/workflows/Node%20CI/badge.svg
73+
[github-actions-url]: https://github.com/codecov/codecov-node/actions?query=workflow%3A%22Node+CI%22
7174
[travis-image]: https://travis-ci.org/codecov/codecov-node.svg?branch=master
7275
[travis-url]: https://travis-ci.org/codecov/codecov-node
73-
[appveyor-image]: https://ci.appveyor.com/api/projects/status/ea1suiv0tprnq61l?svg=true
74-
[appveyor-url]: https://ci.appveyor.com/project/eddiemoore/codecov-node/branch/master
7576
[npm-url]: https://npmjs.org/package/codecov
7677
[npm-image]: https://img.shields.io/npm/v/codecov.svg
7778
[depstat-url]: https://david-dm.org/codecov/codecov-node

appveyor.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ init:
1212
- git config --global core.autocrlf true
1313

1414
install:
15-
- ps: Install-Product node $env:nodejs_version
15+
- ps: Install-Product node $env:nodejs_version x64
1616
- npm install
1717

1818
test_script:

test/upload.test.js

Lines changed: 0 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -67,31 +67,4 @@ describe('Codecov', function() {
6767
}
6868
)
6969
})
70-
71-
it("upload v2 doesn't throw runtime error", function(done) {
72-
expect(
73-
codecov.sendToCodecovV2.bind(
74-
null,
75-
'https://codecov.io',
76-
{
77-
token: 'f881216b-b5c0-4eb1-8f21-b51887d1d506',
78-
commit: 'c739768fcac68144a3a6d82305b9c4106934d31a',
79-
branch: 'master',
80-
},
81-
'testing node-' + codecov.version,
82-
function(body) {
83-
expect(body).toContain(
84-
'https://codecov.io/github/codecov/ci-repo/commit/c739768fcac68144a3a6d82305b9c4106934d31a'
85-
)
86-
done()
87-
},
88-
function(errCode, errMsg) {
89-
if (offlineErrors.indexOf(errCode) !== -1) {
90-
done()
91-
}
92-
throw new Error(errMsg)
93-
}
94-
)
95-
).not.toThrow()
96-
})
9770
})

0 commit comments

Comments
 (0)