Use actual mass, instead of flay score

In classic:

https://github.com/codeclimate/analyzer/blob/master/lib/quality/worker/jobs/smel
l_duplication.rb#L30

Here, we have been using the flay score instead of actual mass:

mass * num_occurrences // similar code

mass * num_occurrences * num_occurrences // identical code

Author: ABaldwinHunter

lib/cc/engine/analyzers/analyzer_base.rb

@@ -36,8 +36,8 @@ def mass_threshold
           engine_config.mass_threshold_for(self.class::LANGUAGE) || self.class::DEFAULT_MASS_THRESHOLD
         end
 
-        def calculate_points(issue)
-          self.class::BASE_POINTS * issue.mass
+        def calculate_points(mass)
+          self.class::BASE_POINTS * mass
         end
 
         private

lib/cc/engine/analyzers/python/main.rb

@@ -14,16 +14,16 @@ class Main < CC::Engine::Analyzers::Base
           DEFAULT_PATHS = ["**/*.py"]
           DEFAULT_MASS_THRESHOLD = 32
           BASE_POINTS = 1_500_000
-          POINTS_PER_OVERAGE = 30_000
+          POINTS_PER_OVERAGE = 50_000
 
-          def calculate_points(issue)
-            BASE_POINTS + (overage(issue) * POINTS_PER_OVERAGE)
+          def calculate_points(mass)
+            BASE_POINTS + (overage(mass) * POINTS_PER_OVERAGE)
           end
 
           private
 
-          def overage(issue)
-            issue.mass - mass_threshold
+          def overage(mass)
+            mass - mass_threshold
           end
 
           def process_file(path)

lib/cc/engine/analyzers/ruby/main.rb

@@ -22,14 +22,14 @@ class Main < CC::Engine::Analyzers::Base
           POINTS_PER_OVERAGE = 100_000
           TIMEOUT = 300
 
-          def calculate_points(issue)
-            BASE_POINTS + (overage(issue) * POINTS_PER_OVERAGE)
+          def calculate_points(mass)
+            BASE_POINTS + (overage(mass) * POINTS_PER_OVERAGE)
           end
 
           private
 
-          def overage(issue)
-            issue.mass - mass_threshold
+          def overage(mass)
+            mass - mass_threshold
           end
 
           def process_file(file)

lib/cc/engine/analyzers/violation.rb

@@ -32,10 +32,18 @@ def report_name
           "#{current_sexp.file}-#{current_sexp.line}"
         end
 
+        def mass
+          flay_score / occurrences # ABH Reverse engineer the actual mass.
+        end
+
         private
 
         attr_reader :language_strategy, :hashes
 
+        def flay_score
+          issue.mass
+        end
+
         def current_sexp
           @location ||= sorted_hashes.first
         end
@@ -57,7 +65,7 @@ def check_name
         end
 
         def calculate_points
-          language_strategy.calculate_points(issue)
+          language_strategy.calculate_points(mass)
         end
 
         def format_location
@@ -96,13 +104,13 @@ def fingerprint
         end
 
         def description
-          description = "#{check_name} found in #{occurrences} other location"
-          description += "s" if occurrences > 1
+          description = "#{check_name} found in #{occurrences - 1} other location"
+          description += "s" if occurrences > 2
           description
         end
 
         def occurrences
-          other_sexps.count
+          other_sexps.count + 1
         end
       end
     end