Skip to content

feat: parallel execution by workers on multiple browsers results with multiple output folders #3971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Nov 7, 2023
Merged

feat: parallel execution by workers on multiple browsers results with multiple output folders #3971

Changes from 2 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
4b99208
feat: run-workers with multiple browers output folders
kobenguyent Nov 3, 2023
07b10d7
feat: run-workers with multiple browers output folders
kobenguyent Nov 3, 2023
530413f
Update workers.js
kobenguyent Nov 4, 2023
262350d
Update workers.js
kobenguyent Nov 4, 2023
4ed86f7
some improvements
kobenguyent Nov 4, 2023
d66acf4
some improvements
kobenguyent Nov 4, 2023
3991048
some improvements
kobenguyent Nov 4, 2023
339f9dc
some improvements
kobenguyent Nov 4, 2023
ba99d49
fix: condition check
kobenguyent Nov 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion lib/workers.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,10 +94,19 @@ const createWorkerObjects = (testGroups, config, testRoot, options, selectedRuns
});
}
const workersToExecute = [];

const currentOutputFolder = config.output;
const currentMochawesomeReportDir = config.mocha.reporterOptions?.mochawesome.options.reportDir;

collection.createRuns(selectedRuns, config).forEach((worker) => {
const _config = { ...config };
_config.output = `${currentOutputFolder}/${worker.config.browser.browser}`;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe ${worker.name} is better than ${worker.config.browser.browser}

Then an output folder name will be e.g. personal:chromium1 (or dev:chromium1) instead of chromium and it's more similar to naming when using run-multiple mode.

The run-multiple mode uses personal_chromium_1 (<profile>_<browser_name>_<browser_order>)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you help tell what worker.name returns?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I run a test in VSCode in debug mode and just saw the value. I guess "worker.name" returns <profile_name>:<browser_name>1.
Not sure for 1 means. I thought that it's a worker ID, but in my testing it's always 1 even for multiple workers (e.g. 2 workers).

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your reply!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, folder name is e.g. dev_firefox1 (profile "dev", browser "firefox") after the latest fixes ✔️ .
Also XML report result.xml is stored to a folder per browser ✔️ .

if (config.mocha && config.mocha.reporterOptions) {
_config.mocha.reporterOptions.mochawesome.options.reportDir = `${currentMochawesomeReportDir}/${worker.config.browser.browser}`;
}
const workerName = worker.getOriginalName() || worker.getName();
const workerConfig = worker.getConfig();
workersToExecute.push(getOverridenConfig(workerName, workerConfig, config));
workersToExecute.push(getOverridenConfig(workerName, workerConfig, _config));
});
const workers = [];
let index = 0;
Expand Down