Fix/bootstrap starting for def #1270
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavertMik
requested changes
Oct 22, 2018
lib/codecept.js
Outdated
| */ | ||
| bootstrap(done) { | ||
| runHooks(done) { |
There was a problem hiding this comment.
looks like runHooks are synchronous now, so done is not needed and callback functions.
Also I'm going to deprecate custom hooks in config so this code should be 100% synchronous
DavertMik
requested changes
Oct 22, 2018
lib/command/gherkin/steps.js
Outdated
| } | ||
| if (err) throw new Error(`Error while running init :${err}`); | ||
|
|
||
| codecept.runBootstrap((err) => { |
There was a problem hiding this comment.
bootstrap should not be run for listing steps definition (as it's not executed for def)
lib/command/gherkin/snippets.js
Outdated
| files.push(fsPath.resolve(file)); | ||
| }); | ||
| output.print(`Loaded ${files.length} files`); | ||
| codecept.runBootstrap((err) => { |
There was a problem hiding this comment.
gherkin:snippets should not execute bootstrap (as it's omitted for def/list commands as well)
|
Done 1st and 3rd. About 2nd: |
DavertMik
approved these changes
Oct 23, 2018
|
Awesome, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed config's bootstrap and teardown calls for
codeceptjs defandcodeceptjs listBefore, bootstrap has started (and set up connection to browserstack, for example) before
defcommand, which is unnecessary.Also, teardown has started after these commands.
TypeError: done is not a functionerror occurred.